Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise constructor #23158

Merged
merged 3 commits into from Apr 6, 2019

Conversation

Projects
None yet
7 participants
@AZWN
Copy link
Contributor

commented Apr 3, 2019

In this PR, measures are taken that prevent the Promise::new constructor from being used outside a compartment.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22982 (GitHub issue number if applicable)
  • These changes do not require tests because no new functionality is added.

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Apr 3, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @avadacatavra (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

commented Apr 3, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/navigator.rs, components/script/dom/rtcpeerconnection.rs, components/script/dom/vrdisplay.rs, components/script/dom/customelementregistry.rs, components/script/dom/baseaudiocontext.rs and 20 more
  • @KiChjang: components/script/dom/navigator.rs, components/script/dom/rtcpeerconnection.rs, components/script/dom/vrdisplay.rs, components/script/dom/customelementregistry.rs, components/script/dom/baseaudiocontext.rs and 20 more
@highfive

This comment has been minimized.

Copy link

commented Apr 3, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@KiChjang

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

⌛️ Trying commit 60ba3d2 with merge 474d933...

bors-servo added a commit that referenced this pull request Apr 3, 2019

Auto merge of #23158 - BartGitHub:promise-constructor, r=<try>
Promise constructor

<!-- Please describe your changes on the following line: -->
In this PR, measures are taken that prevent the ```Promise::new``` constructor from being used outside a compartment.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22982 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because no new functionality is added.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23158)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

@AZWN

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@KiChjang I see the tests are passing. Is there still something that needs to be done for this PR?

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

r? @jdm

@highfive highfive assigned jdm and unassigned avadacatavra Apr 5, 2019

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Thanks! Even though these changes do not actually make any of the existing code any safer, it makes the unsafety of the existing code more clear, and makes it easier to recognize when we're adding new cases that could crash in the future.
@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

📌 Commit 60ba3d2 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

⌛️ Testing commit 60ba3d2 with merge 4d1540f...

bors-servo added a commit that referenced this pull request Apr 5, 2019

Auto merge of #23158 - BartGitHub:promise-constructor, r=jdm
Promise constructor

In this PR, measures are taken that prevent the ```Promise::new``` constructor from being used outside a compartment.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22982 (GitHub issue number if applicable)

<!-- Either: -->
- [x] These changes do not require tests because no new functionality is added.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23158)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

💔 Test failed - status-taskcluster

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

💣 Failed to start rebuilding: Unknown error

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

⌛️ Testing commit 60ba3d2 with merge 969fdd8...

bors-servo added a commit that referenced this pull request Apr 5, 2019

Auto merge of #23158 - BartGitHub:promise-constructor, r=jdm
Promise constructor

In this PR, measures are taken that prevent the ```Promise::new``` constructor from being used outside a compartment.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22982 (GitHub issue number if applicable)

<!-- Either: -->
- [x] These changes do not require tests because no new functionality is added.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23158)
<!-- Reviewable:end -->

@highfive highfive removed the S-tests-failed label Apr 5, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

💔 Test failed - mac-rel-wpt4

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

⌛️ Testing commit 60ba3d2 with merge 6bfc787...

bors-servo added a commit that referenced this pull request Apr 5, 2019

Auto merge of #23158 - BartGitHub:promise-constructor, r=jdm
Promise constructor

In this PR, measures are taken that prevent the ```Promise::new``` constructor from being used outside a compartment.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22982 (GitHub issue number if applicable)

<!-- Either: -->
- [x] These changes do not require tests because no new functionality is added.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23158)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

💔 Test failed - mac-rel-css1

@CYBAI

This comment has been minimized.

Copy link
Collaborator

commented Apr 6, 2019

@bors-servo retry

  ▶ TIMEOUT [expected OK] /url/urlsearchparams-constructor.any.html
  │ 
  │ VMware, Inc.
  │ softpipe
  │ 3.3 (Core Profile) Mesa 18.3.0-devel
  │ alloc factor 0.010000 0.900000
  └ alloc factor 0.010000 0.900000
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

⌛️ Testing commit 60ba3d2 with merge c87b4aa...

bors-servo added a commit that referenced this pull request Apr 6, 2019

Auto merge of #23158 - BartGitHub:promise-constructor, r=jdm
Promise constructor

In this PR, measures are taken that prevent the ```Promise::new``` constructor from being used outside a compartment.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22982 (GitHub issue number if applicable)

<!-- Either: -->
- [x] These changes do not require tests because no new functionality is added.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23158)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

💔 Test failed - status-taskcluster

@CYBAI

This comment has been minimized.

Copy link
Collaborator

commented Apr 6, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

💣 Failed to start rebuilding: Unknown error

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

⌛️ Testing commit 60ba3d2 with merge be1e069...

bors-servo added a commit that referenced this pull request Apr 6, 2019

Auto merge of #23158 - BartGitHub:promise-constructor, r=jdm
Promise constructor

In this PR, measures are taken that prevent the ```Promise::new``` constructor from being used outside a compartment.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22982 (GitHub issue number if applicable)

<!-- Either: -->
- [x] These changes do not require tests because no new functionality is added.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23158)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

@bors-servo bors-servo merged commit 60ba3d2 into servo:master Apr 6, 2019

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@AZWN AZWN deleted the BartGitHub:promise-constructor branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.