Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XR code to use rigid transforms and new pose/transform stuff from the spec #23159

Merged
merged 13 commits into from Apr 4, 2019
Merged

Update XR code to use rigid transforms and new pose/transform stuff from the spec #23159

merged 13 commits into from Apr 4, 2019
+225 −216

Commits on Apr 4, 2019

  1. Bump euclid to 0.19.7

    @Manishearth
    Manishearth committed Apr 4, 2019
    67694dc

  2. Move XRRigidTransform to using RigidTransform3D

    @Manishearth
    Manishearth committed Apr 4, 2019
    feb3517

  3. Make XRRigidTransform.position/orientation lazy, default to using euc… 

    …lid things
    @Manishearth
    Manishearth committed Apr 4, 2019
    e296185

  4. Validate the position passed to XRRigidTransform 

    Added in immersive-web/webxr#568
    @Manishearth
    Manishearth committed Apr 4, 2019
    1f3f372

  5. Switch XRSpace code to using rigid transforms

    @Manishearth
    Manishearth committed Apr 4, 2019
    08079c4

  6. Add empty XRPose interface

    @Manishearth
    Manishearth committed Apr 4, 2019
    e1f0ad7

  7. Add XRPose.transform

    @Manishearth
    Manishearth committed Apr 4, 2019
    f9c25c6

  8. Make XRViewerPose inherit from XRPose

    @Manishearth
    Manishearth committed Apr 4, 2019
    f7745ed

  9. Consistently use GlobalScope in XR code

    @Manishearth
    Manishearth committed Apr 4, 2019
    fcec93a

  10. XRRigidTransform.inverse is now a lazy attribute

    @Manishearth
    Manishearth committed Apr 4, 2019
    eb837d1

  11. Add XRView.transform

    @Manishearth
    Manishearth committed Apr 4, 2019
    646647e

  12. Add XRRigidTransform.matrix

    @Manishearth
    Manishearth committed Apr 4, 2019
    e73920e

  13. Remove viewMatrix 

    Users are supposed to use `view.transform.inverse.matrix`

The view matrix was incorrect anyway, we had forgotten to invert it, but that was okay since we transposed it by accident (due to euclid's use of the row-vector convention), and for 3DOF devices these transforms are mostly rotations so  transposing instead of inverting doesn't lead to visible effects.
    @Manishearth
    Manishearth committed Apr 4, 2019
    Loading status checks…
    e055884
You can’t perform that action at this time.