Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webdriver command "Find elements from Element" #23171

Merged
merged 5 commits into from May 19, 2019

Conversation

Projects
None yet
6 participants
@hundredeir
Copy link
Contributor

commented Apr 6, 2019


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Apr 6, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

commented Apr 6, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/script_thread.rs, components/script/webdriver_handlers.rs, components/webdriver_server/lib.rs
  • @jgraham: components/webdriver_server/lib.rs
  • @KiChjang: components/script/script_thread.rs, components/script_traits/webdriver_msg.rs, components/script/webdriver_handlers.rs
@highfive

This comment has been minimized.

Copy link

commented Apr 6, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

@nox review ping

Show resolved Hide resolved components/webdriver_server/lib.rs Outdated
Show resolved Hide resolved components/webdriver_server/lib.rs Outdated

@jdm jdm assigned jdm and unassigned nox Apr 30, 2019

@jdm

This comment has been minimized.

Copy link
Member

commented May 17, 2019

@bors-servo r+
Sorry about the delay in reviewing this!

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

📌 Commit 6f764fb has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

⌛️ Testing commit 6f764fb with merge b8fd186...

bors-servo added a commit that referenced this pull request May 17, 2019

Auto merge of #23171 - hundredeir:find_elem_elems, r=jdm
add webdriver command "Find elements from Element"

Draft request
Testing is not complete yet.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23171)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

💔 Test failed - status-taskcluster

@CYBAI

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2019

@bors-servo retry

  • #JustInfraThings
curl: (7) Failed to connect to download.gnome.org port 443: Operation timed out
Error: An exception occurred within a child process:
  DownloadError: Failed to download resource "libsoup"
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

⌛️ Testing commit 6f764fb with merge 14c6fa5...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

💔 Test failed - status-taskcluster

@CYBAI

This comment has been minimized.

Copy link
Collaborator

commented May 19, 2019

@bors-servo retry

/bin/ld: fatal error: out of file descriptors and couldn't close any
          collect2: error: ld returned 1 exit status
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

⌛️ Testing commit 6f764fb with merge 7cc4a26...

bors-servo added a commit that referenced this pull request May 19, 2019

Auto merge of #23171 - hundredeir:find_elem_elems, r=jdm
add webdriver command "Find elements from Element"

Draft request
Testing is not complete yet.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23171)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

💔 Test failed - status-taskcluster

@jdm

This comment has been minimized.

Copy link
Member

commented May 19, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

⌛️ Testing commit 6f764fb with merge 03d0137...

bors-servo added a commit that referenced this pull request May 19, 2019

Auto merge of #23171 - hundredeir:find_elem_elems, r=jdm
add webdriver command "Find elements from Element"

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23171)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

💔 Test failed - status-taskcluster

@jdm

This comment has been minimized.

Copy link
Member

commented May 19, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

💣 Failed to start rebuilding: Unknown error

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

⌛️ Testing commit 6f764fb with merge 7e766e9...

bors-servo added a commit that referenced this pull request May 19, 2019

Auto merge of #23171 - hundredeir:find_elem_elems, r=jdm
add webdriver command "Find elements from Element"

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23171)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 19, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 7e766e9 to master...

@bors-servo bors-servo merged commit 6f764fb into servo:master May 19, 2019

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@hundredeir hundredeir deleted the hundredeir:find_elem_elems branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.