Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note to indicate PKG_CONFIG_PATH required #23175

Merged
merged 1 commit into from Apr 7, 2019
Merged

Add a note to indicate PKG_CONFIG_PATH required #23175

merged 1 commit into from Apr 7, 2019

Conversation

@CYBAI
Copy link
Collaborator

CYBAI commented Apr 7, 2019 •
edited by SimonSapin

I just got the error messages like #23015 again and then I think the root cause should be about
PKG_CONFIG_PATH. After following #23015 (comment) said, I can build Servo successfully.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because this just updates README.

This change is Reviewable
@CYBAI
Add a note to indicate PKG_CONFIG_PATH required
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aa0b4ab
@jdm
Copy link
Member

jdm commented Apr 7, 2019

@bors-servo r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2019

📌 Commit aa0b4ab has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Apr 7, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2019

⌛ Testing commit aa0b4ab with merge 1a21c04...
bors-servo added a commit that referenced this pull request Apr 7, 2019
@bors-servo
Auto merge of #23175 - servo:CYBAI-patch-1, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1a21c04 
Add a note to indicate PKG_CONFIG_PATH required

I just got the error messages like #23015 again and then I think the root cause should be about
`PKG_CONFIG_PATH`. After following #23015 (comment) said, I can build Servo successfully.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because this just updates README.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23175)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 1a21c04 to master...
@bors-servo bors-servo merged commit aa0b4ab into master Apr 7, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@CYBAI CYBAI deleted the CYBAI-patch-1 branch Apr 7, 2019
@CYBAI CYBAI mentioned this pull request Apr 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@CYBAI @jdm @bors-servo @asajeffrey @highfive
You can’t perform that action at this time.