Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace panic with warn in DocumentLoader.finish_load. #23183

Merged
merged 1 commit into from Apr 11, 2019
Merged

Replace panic with warn in DocumentLoader.finish_load. #23183

merged 1 commit into from Apr 11, 2019

Conversation

@krk
Copy link
Contributor

krk commented Apr 9, 2019 •
edited by SimonSapin

Fix panic on broken script URL with an onerror handler that rewrites the document.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #23144

This change is Reviewable
@krk
Replace panic with warn in DocumentLoader.finish_load.
Loading status checks…
211fb00 
Fix panic on broken script URL with an onerror handler that rewrites the
document.
@highfive
Copy link

highfive commented Apr 9, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @ferjm (or someone else) soon.
@highfive
Copy link

highfive commented Apr 9, 2019

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Apr 9, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@krk krk force-pushed the krk:fix-23144 branch from 6e8f1a5 to 211fb00 Apr 9, 2019
@asajeffrey
Copy link
Member

asajeffrey commented Apr 9, 2019

LGTM! Yay for less panic. @bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2019

📌 Commit 211fb00 has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned ferjm Apr 9, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2019

⌛ Testing commit 211fb00 with merge 8930806...
bors-servo added a commit that referenced this pull request Apr 10, 2019
@bors-servo
Auto merge of #23183 - krk:fix-23144, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8930806 
Replace panic with warn in DocumentLoader.finish_load.

Fix panic on broken script URL with an onerror handler that rewrites the document.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23144

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23183)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Apr 10, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2019

⌛ Testing commit 211fb00 with merge 1aa86d2...
bors-servo added a commit that referenced this pull request Apr 10, 2019
@bors-servo
Auto merge of #23183 - krk:fix-23144, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1aa86d2 
Replace panic with warn in DocumentLoader.finish_load.

Fix panic on broken script URL with an onerror handler that rewrites the document.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23144

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23183)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Apr 10, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2019

⌛ Testing commit 211fb00 with merge db9300d...
bors-servo added a commit that referenced this pull request Apr 11, 2019
@bors-servo
Auto merge of #23183 - krk:fix-23144, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
db9300d 
Replace panic with warn in DocumentLoader.finish_load.

Fix panic on broken script URL with an onerror handler that rewrites the document.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23144

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23183)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: asajeffrey
Pushing db9300d to master...
@bors-servo bors-servo merged commit 211fb00 into servo:master Apr 11, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Servo panics when loading a broken script URL with an onerror handler that rewrites the document
7 participants
@krk @highfive @asajeffrey @bors-servo @CYBAI @jdm @ferjm
You can’t perform that action at this time.