Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTMLMediaElement.crossorigin attribute logic. #23188

Merged
merged 1 commit into from May 22, 2019

Conversation

@jackxbritton
Copy link
Contributor

@jackxbritton jackxbritton commented Apr 10, 2019


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22287
  • There are tests for these changes

This change is Reviewable

@highfive
Copy link

@highfive highfive commented Apr 10, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

@highfive
Copy link

@highfive highfive commented Apr 10, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs
  • @KiChjang: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs

@@ -1,31 +1,31 @@
[crossOrigin.html]
[HTMLMediaElement.crossOrigin, setting to invalid value]
expected: FAIL
expected: PASS
Copy link
Member

@KiChjang KiChjang Apr 10, 2019

If these subtests all pass, you can actually delete this file. By default, all tests are expected to PASS, so having no INI file means exactly that.

Copy link
Contributor Author

@jackxbritton jackxbritton Apr 10, 2019

Oh neat, thanks.

@@ -1017,7 +1017,7 @@
expected: FAIL

[HTMLMediaElement interface: document.createElement("video") must inherit property "crossOrigin" with the proper type]
expected: FAIL
expected: PASS
Copy link
Member

@KiChjang KiChjang Apr 11, 2019

For these PASSes, instead of removing the file, you can just remove the line above and this line:

Suggested change
expected: PASS

@jdm
Copy link
Member

@jdm jdm commented Apr 11, 2019

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Apr 11, 2019

Trying commit 2818ff0 with merge 650bfb1...

bors-servo added a commit that referenced this issue Apr 11, 2019
Implement HTMLMediaElement.crossorigin attribute logic.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22287  (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23188)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Apr 11, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

@jackxbritton
Copy link
Contributor Author

@jackxbritton jackxbritton commented Apr 11, 2019

Oh yeah

Copy link
Member

@KiChjang KiChjang left a comment

Looks mostly fine to me, only a minor nit about documentation. Thanks for you contribution!

components/script/dom/htmlmediaelement.rs Outdated Show resolved Hide resolved
@ferjm
Copy link
Member

@ferjm ferjm commented May 10, 2019

@jackxbritton are you still working on this PR? Rebasing and addressing @KiChjang's feedback should be enough to merge. Thanks!

@ferjm
Copy link
Member

@ferjm ferjm commented May 22, 2019

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 22, 2019

Trying commit a2e0266 with merge 901b6fb...

bors-servo added a commit that referenced this issue May 22, 2019
Implement HTMLMediaElement.crossorigin attribute logic.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22287  (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23188)
<!-- Reviewable:end -->
@ferjm
Copy link
Member

@ferjm ferjm commented May 22, 2019

@bors-servo r=KiChjang,ferjm

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 22, 2019

📌 Commit ade697b has been approved by KiChjang,ferjm

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 22, 2019

Testing commit ade697b with merge 377ade0...

bors-servo added a commit that referenced this issue May 22, 2019
Implement HTMLMediaElement.crossorigin attribute logic.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #22287
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23188)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 22, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: KiChjang,ferjm
Pushing 377ade0 to master...

@bors-servo bors-servo merged commit ade697b into servo:master May 22, 2019
4 checks passed
@bors-servo bors-servo mentioned this pull request May 22, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

8 participants