Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement HTMLMediaElement.crossorigin attribute logic. #23188
Merged
Conversation
highfive
commented
Apr 10, 2019
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. |
highfive
commented
Apr 10, 2019
|
Heads up! This PR modifies the following files:
|
...embedded-content/media-elements/interfaces/HTMLElement/HTMLMediaElement/crossOrigin.html.ini
Outdated
| @@ -1,31 +1,31 @@ | |||
| [crossOrigin.html] | |||
| [HTMLMediaElement.crossOrigin, setting to invalid value] | |||
| expected: FAIL | |||
| expected: PASS | |||
This comment has been minimized.
This comment has been minimized.
KiChjang
Apr 10, 2019
Member
If these subtests all pass, you can actually delete this file. By default, all tests are expected to PASS, so having no INI file means exactly that.
This comment has been minimized.
This comment has been minimized.
| @@ -1017,7 +1017,7 @@ | |||
| expected: FAIL | |||
|
|
|||
| [HTMLMediaElement interface: document.createElement("video") must inherit property "crossOrigin" with the proper type] | |||
| expected: FAIL | |||
| expected: PASS | |||
This comment has been minimized.
This comment has been minimized.
KiChjang
Apr 11, 2019
Member
For these PASSes, instead of removing the file, you can just remove the line above and this line:
Suggested change
| expected: PASS |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Apr 11, 2019
Implement HTMLMediaElement.crossorigin attribute logic. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #22287 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23188) <!-- Reviewable:end -->
|
|
|
Oh yeah |
|
Looks mostly fine to me, only a minor nit about documentation. Thanks for you contribution! |
|
@jackxbritton are you still working on this PR? Rebasing and addressing @KiChjang's feedback should be enough to merge. Thanks! |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
May 22, 2019
Implement HTMLMediaElement.crossorigin attribute logic. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #22287 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23188) <!-- Reviewable:end -->
|
@bors-servo r=KiChjang,ferjm |
|
|
bors-servo
added a commit
that referenced
this pull request
May 22, 2019
Implement HTMLMediaElement.crossorigin attribute logic. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #22287 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23188) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jackxbritton commentedApr 10, 2019
•
edited by ferjm
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is