Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of RefCell::try_borrow_unguarded #23196

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
5 participants
@nox
Copy link
Member

commented Apr 12, 2019

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Apr 12, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/cell.rs, components/script/lib.rs, components/script/dom/xmlhttprequest.rs
  • @KiChjang: components/script/dom/bindings/cell.rs, components/script/lib.rs, components/script/dom/xmlhttprequest.rs
@highfive

This comment has been minimized.

Copy link

commented Apr 12, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@nox nox force-pushed the rustup branch from 65699f6 to 048a1c8 Apr 12, 2019

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

📌 Commit 048a1c8 has been approved by jdm

@highfive highfive assigned jdm and unassigned Manishearth Apr 12, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

⌛️ Testing commit 048a1c8 with merge 2d6e5b4...

bors-servo added a commit that referenced this pull request Apr 12, 2019

Auto merge of #23196 - servo:rustup, r=jdm
Make use of RefCell::try_borrow_unguarded

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23196)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

New warnings reported by the rustc update:

error: the item `log` is imported redundantly
   --> components/style/error_reporting.rs:248:13
    |
248 |         use log;
    |             ^^^
    | 
   ::: components/style/lib.rs:59:1
    |
59  | extern crate log;
    | ----------------- the item `log` is already imported here
    |
    = note: `-D unused-imports` implied by `-D warnings`

error: the item `ElementState` is imported redundantly
   --> components/style/servo/selector_parser.rs:357:13
    |
11  | use crate::element_state::{DocumentState, ElementState};
    |                                           ------------ the item `ElementState` is already imported here
...
357 |         use crate::element_state::ElementState;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: ignoring -C extra-filename flag due to -o flag

error: aborting due to 2 previous errors

error: Could not compile `style`.
@nox

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

@bors-servo r=jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

📌 Commit 4416314 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

⌛️ Testing commit 4416314 with merge 8318624...

bors-servo added a commit that referenced this pull request Apr 12, 2019

Auto merge of #23196 - servo:rustup, r=jdm
Make use of RefCell::try_borrow_unguarded

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23196)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

@bors-servo bors-servo merged commit 4416314 into master Apr 12, 2019

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@SimonSapin SimonSapin referenced this pull request May 15, 2019

Open

Tracking issue for `borrow_state` stabilization #27733

0 of 1 task complete

SimonSapin added a commit to SimonSapin/rust that referenced this pull request May 15, 2019

Stabilize RefCell::try_borrow_unguarded
Servo has been using this since servo/servo#23196 to add a runtime check to some unsafe code, as discussed in PR rust-lang#59211. Stabilizing would help do more of the same in libraries that also have users on Stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.