Implement PerformanceNavigation interface #23203

iulianR · 2019-04-15T16:31:01Z

This is my first attempt. Please let me know if I should change anything.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #22828 (GitHub issue number if applicable)

There are tests for these changes OR
These changes do not require tests because not sure

This change is

highfive · 2019-04-15T16:31:13Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @avadacatavra (or someone else) soon.

highfive · 2019-04-15T16:31:15Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/Performance.webidl, components/script/dom/mod.rs, components/script/dom/webidls/PerformanceNavigation.webidl, components/script/dom/performance.rs, components/script/dom/performancenavigation.rs
@KiChjang: components/script/dom/webidls/Performance.webidl, components/script/dom/mod.rs, components/script/dom/webidls/PerformanceNavigation.webidl, components/script/dom/performance.rs, components/script/dom/performancenavigation.rs

highfive · 2019-04-15T16:31:18Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

jdm · 2019-04-15T16:40:20Z

@bors-servo try=wpt


        Auto merge of #23203 - iulianR:22828, r=<try>

Implement PerformanceNavigation interface  This is my first attempt. Please let me know if I should change anything. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22828 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because **not sure**    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23203)

bors-servo · 2019-04-15T16:40:28Z

⌛ Trying commit e232ee6 with merge 8687b1f...

bors-servo · 2019-04-15T17:01:09Z

💔 Test failed - linux-rel-css

iulianR · 2019-04-15T18:07:20Z

I see that I should update the mozzila/interfaces.html with PerformanceNavigation, but I'm not sure what to do with the tests in worker-performance.worker.js. What should they test now?

jdm · 2019-04-15T18:57:24Z

There are also a lot of new test results in https://build.servo.org/builders/linux-rel-wpt/builds/12027/steps/shell__4/logs/filtered-wpt-errorsummary.log . I recommend following the instructions at https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations using a log generated from ./mach test-wpt tests/wpt/web-platform-tests/navigation-timing/ --log-raw /tmp/servo.log.

components/script/dom/webidls/Performance.webidl

iulianR · 2019-04-15T20:34:48Z

I also noticed this warning that I don't think was there before. It is, however, not clear to me what it means.

warning: unused attribute
  --> components/script/dom/bindings/conversions.rs:74:5
   |
74 |     rustc_on_unimplemented(message = "The IDL interface `{Self}` is not derived from `{T}`.")
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(unused_attributes)] on by default

jdm · 2019-04-15T20:45:43Z

It comes and goes, and is not related to your changes.

iulianR · 2019-04-15T20:57:09Z

I updated the tests as you asked, although there were more changes than I expected.

jdm · 2019-04-15T21:25:26Z

@iulianR Would you mind squashing your commits into one?

jdm · 2019-04-22T20:46:23Z

@bors-servo r+
Sorry about the delay!

bors-servo · 2019-04-22T20:46:24Z

📌 Commit fedc46f has been approved by jdm


        Auto merge of #23203 - iulianR:22828, r=jdm

Implement PerformanceNavigation interface  This is my first attempt. Please let me know if I should change anything. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22828 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because **not sure**    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23203)


        Implement PerformanceNavigation interface

jdm · 2019-06-28T13:45:16Z

@bors-servo r+

bors-servo · 2019-06-28T13:45:17Z

📌 Commit 62f0785 has been approved by jdm

bors-servo · 2019-06-28T13:45:22Z

⌛ Testing commit 62f0785 with merge 500369a...


        Auto merge of #23203 - iulianR:22828, r=jdm

Implement PerformanceNavigation interface  This is my first attempt. Please let me know if I should change anything. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22828 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because **not sure**    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23203)

bors-servo · 2019-06-28T14:10:25Z

💔 Test failed - linux-rel-css

iulianR · 2019-06-28T14:21:11Z

Hmm, I assumed the problem with the worker was fixed now, so I didn't update the expected test result.

I'm digging into the issue with the worker separately. I recommend updating the expected test results for /workers/worker-performance.worker.html as an expected failure so we can merge these changes.

I will do this now.

jdm · 2019-06-28T14:31:20Z

The worker issue is being fixed in #23500 but isn't ready yet.

jdm · 2019-07-12T21:17:58Z

@iulianR Are you still planning to finish this? :)

iulianR · 2019-07-15T16:57:34Z

@jdm Can you tell me how I should run the tests so I can figure out if the change I made (locally) was good? I still don't fully understand the testing framework.

jdm · 2019-07-15T17:07:14Z

You can run tests locally like so: ./mach test-wpt tests/wpt/web-platform-tests/workers/worker-performance.any.js

jdm · 2019-07-15T17:07:40Z

Since #23500 has merged, let's see if that's good enough, though!
@bors-servo try=wpt

jdm · 2019-07-15T17:08:23Z

@bors-servo clean try=wpt retry

bors-servo · 2019-07-15T17:08:29Z

⌛ Trying commit 62f0785 with merge 5b800d2...


        Auto merge of #23203 - iulianR:22828, r=<try>

Implement PerformanceNavigation interface  This is my first attempt. Please let me know if I should change anything. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22828 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because **not sure**    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23203)

bors-servo · 2019-07-15T17:55:30Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved=jdm try=True

bors-servo · 2019-07-15T17:55:35Z

⌛ Testing commit 62f0785 with merge 005320c...


        Auto merge of #23203 - iulianR:22828, r=jdm

Implement PerformanceNavigation interface  This is my first attempt. Please let me know if I should change anything. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22828 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [x] These changes do not require tests because **not sure**    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23203)

bors-servo · 2019-07-15T20:42:55Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 005320c to master...

highfive assigned avadacatavra Apr 15, 2019

highfive added the S-awaiting-review label Apr 15, 2019

highfive added the S-tests-failed label Apr 15, 2019

jdm reviewed Apr 15, 2019

View changes

components/script/dom/webidls/Performance.webidl Outdated Show resolved Hide resolved

highfive removed the S-tests-failed label Apr 15, 2019

jdm added S-needs-squash and removed S-awaiting-review labels Apr 15, 2019

iulianR force-pushed the iulianR:22828 branch from 4e86195 to fedc46f Apr 15, 2019

highfive added the S-awaiting-review label Apr 15, 2019

highfive assigned jdm and unassigned avadacatavra Apr 22, 2019

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-squash labels Apr 22, 2019

Implement PerformanceNavigation interface

Loading status checks…

62f0785

iulianR force-pushed the iulianR:22828 branch from 355df1f to 62f0785 Jun 25, 2019

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Jun 28, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 28, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Jul 15, 2019

highfive removed the S-awaiting-merge label Jul 15, 2019

iulianR deleted the iulianR:22828 branch Jul 16, 2019

servo / servo

Implement PerformanceNavigation interface #23203

Implement PerformanceNavigation interface #23203

iulianR commented Apr 15, 2019 •

edited by jdm

highfive commented Apr 15, 2019

highfive commented Apr 15, 2019

highfive commented Apr 15, 2019

jdm commented Apr 15, 2019

bors-servo commented Apr 15, 2019

bors-servo commented Apr 15, 2019

iulianR commented Apr 15, 2019

jdm commented Apr 15, 2019

iulianR commented Apr 15, 2019

jdm commented Apr 15, 2019

iulianR commented Apr 15, 2019

jdm commented Apr 15, 2019

jdm commented Apr 22, 2019

bors-servo commented Apr 22, 2019

jdm commented Jun 28, 2019

bors-servo commented Jun 28, 2019

bors-servo commented Jun 28, 2019

bors-servo commented Jun 28, 2019

iulianR commented Jun 28, 2019 •

edited

jdm commented Jun 28, 2019

jdm commented Jul 12, 2019

iulianR commented Jul 15, 2019

jdm commented Jul 15, 2019

jdm commented Jul 15, 2019

jdm commented Jul 15, 2019

bors-servo commented Jul 15, 2019

bors-servo commented Jul 15, 2019

bors-servo commented Jul 15, 2019

bors-servo commented Jul 15, 2019

servo / servo

Join GitHub today

Implement PerformanceNavigation interface #23203

Implement PerformanceNavigation interface #23203

Conversation

iulianR commented Apr 15, 2019 • edited by jdm

highfive commented Apr 15, 2019

highfive commented Apr 15, 2019

highfive commented Apr 15, 2019

jdm commented Apr 15, 2019

bors-servo commented Apr 15, 2019

bors-servo commented Apr 15, 2019

iulianR commented Apr 15, 2019

jdm commented Apr 15, 2019

iulianR commented Apr 15, 2019

jdm commented Apr 15, 2019

iulianR commented Apr 15, 2019

jdm commented Apr 15, 2019

jdm commented Apr 22, 2019

bors-servo commented Apr 22, 2019

jdm commented Jun 28, 2019

bors-servo commented Jun 28, 2019

bors-servo commented Jun 28, 2019

bors-servo commented Jun 28, 2019

iulianR commented Jun 28, 2019 • edited

jdm commented Jun 28, 2019

jdm commented Jul 12, 2019

iulianR commented Jul 15, 2019

jdm commented Jul 15, 2019

jdm commented Jul 15, 2019

jdm commented Jul 15, 2019

bors-servo commented Jul 15, 2019

bors-servo commented Jul 15, 2019

bors-servo commented Jul 15, 2019

bors-servo commented Jul 15, 2019

iulianR commented Apr 15, 2019 •

edited by jdm

iulianR commented Jun 28, 2019 •

edited