Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows x86 build job. #23211

Merged
merged 1 commit into from Apr 26, 2019
Merged

Add Windows x86 build job. #23211

merged 1 commit into from Apr 26, 2019

Conversation

@jdm
Copy link
Member

jdm commented Apr 16, 2019 •
edited by SimonSapin

This will make it easier to start working on Hololens embedding work without having to deal with a broken build first.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Apr 16, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/build.rs, components/script/vcvars.bat
  • @KiChjang: components/script/build.rs, components/script/vcvars.bat
@highfive
Copy link

highfive commented Apr 16, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member Author

jdm commented Apr 16, 2019

@bors-servo try=windows
bors-servo added a commit that referenced this pull request Apr 16, 2019
@bors-servo
Auto merge of #23211 - jdm:win-cross, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7b977a8 
Add Windows x86 build job.

This will make it easier to start working on Hololens embedding work without having to deal with a broken build first.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23211)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2019

⌛ Trying commit 847cd01 with merge 7b977a8...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2019

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:win-cross branch from 847cd01 to 9d899af Apr 16, 2019
@jdm jdm force-pushed the jdm:win-cross branch from 9d899af to ae2c5f1 Apr 16, 2019
@jdm
Copy link
Member Author

jdm commented Apr 16, 2019

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2019

⌛ Trying commit ae2c5f1 with merge a746ac2...
bors-servo added a commit that referenced this pull request Apr 16, 2019
@bors-servo
Auto merge of #23211 - jdm:win-cross, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a746ac2 
Add Windows x86 build job.

This will make it easier to start working on Hololens embedding work without having to deal with a broken build first.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23211)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2019

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:win-cross branch from ae2c5f1 to 0ceaff2 Apr 16, 2019
@jdm jdm force-pushed the jdm:win-cross branch from 0ceaff2 to 2fc438a Apr 16, 2019
@jdm
Copy link
Member Author

jdm commented Apr 16, 2019

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2019

⌛ Trying commit 2fc438a with merge bf5036f...
bors-servo added a commit that referenced this pull request Apr 16, 2019
@bors-servo
Auto merge of #23211 - jdm:win-cross, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bf5036f 
Add Windows x86 build job.

This will make it easier to start working on Hololens embedding work without having to deal with a broken build first.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23211)
<!-- Reviewable:end -->
@jdm jdm force-pushed the jdm:win-cross branch from 2fc438a to 9184ed7 Apr 16, 2019
@jdm
Copy link
Member Author

jdm commented Apr 16, 2019

@bors-servo try=windows
bors-servo added a commit that referenced this pull request Apr 16, 2019
@bors-servo
Auto merge of #23211 - jdm:win-cross, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
544159e 
Add Windows x86 build job.

This will make it easier to start working on Hololens embedding work without having to deal with a broken build first.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23211)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2019

⌛ Trying commit 9184ed7 with merge 544159e...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2019

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:win-cross branch from 9184ed7 to e52adb1 Apr 16, 2019
@jdm jdm removed the S-needs-rebase label Apr 25, 2019
@jdm
Copy link
Member Author

jdm commented Apr 25, 2019

This successfully built on taskcluster. This is ready for review, @SimonSapin.
@SimonSapin
Copy link
Member

SimonSapin commented Apr 26, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

📌 Commit be923fe has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

⌛ Testing commit be923fe with merge 8049f44...
bors-servo added a commit that referenced this pull request Apr 26, 2019
@bors-servo
Auto merge of #23211 - jdm:win-cross, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8049f44 
Add Windows x86 build job.

This will make it easier to start working on Hololens embedding work without having to deal with a broken build first.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23211)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

💔 Test failed - android-mac
@jdm
Add Windows x86 build job.
Loading status checks…
57d241f
@jdm jdm force-pushed the jdm:win-cross branch from be923fe to 57d241f Apr 26, 2019
@jdm
Copy link
Member Author

jdm commented Apr 26, 2019

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

📌 Commit 57d241f has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

⌛ Testing commit 57d241f with merge b4a2d60...
bors-servo added a commit that referenced this pull request Apr 26, 2019
@bors-servo
Auto merge of #23211 - jdm:win-cross, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b4a2d60 
Add Windows x86 build job.

This will make it easier to start working on Hololens embedding work without having to deal with a broken build first.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23211)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: SimonSapin
Pushing b4a2d60 to master...
@bors-servo bors-servo merged commit 57d241f into servo:master Apr 26, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
This was referenced Apr 26, 2019
Merged
Open
@jdm jdm mentioned this pull request Apr 26, 2019
Merged
bors-servo added a commit that referenced this pull request Apr 26, 2019
@bors-servo
Auto merge of #23275 - servo:jdm-patch-37, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
868eaf6 
Use llvm's linker for x86 builds.

This is a follow up to #23256 and #23211.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23275)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Apr 26, 2019
@bors-servo
Auto merge of #23275 - servo:jdm-patch-37, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1b7332b 
Use llvm's linker for x86 builds.

This is a follow up to #23256 and #23211.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23275)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Apr 27, 2019
@bors-servo
Auto merge of #23275 - servo:jdm-patch-37, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
630cf27 
Use llvm's linker for x86 builds.

This is a follow up to #23256 and #23211.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23275)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @bors-servo @SimonSapin @Manishearth
You can’t perform that action at this time.