Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd virtualenv installation to build documentation. #23212
Closed
Conversation
ShalokShalom
commented
Apr 16, 2019
|
I heard that pip and similar tools can mess up rolling systems. Is that true? |
|
I have no idea, but I don't know of a better way to install an importable virtualenv module. |
ShalokShalom
commented
Apr 16, 2019
|
Well, if thats true, no way would be a safer way in this case. My maintainer (of the distro) says this, so.. |
samj1912
commented
Apr 19, 2019
•
|
This should instead be using We should never sudo pip install things. Also on most Linux distros you can find a virtualenv package and with python3.4+ venv is a stdlib module if python is built with |
ShalokShalom
commented
Apr 20, 2019
|
Oh, nice to know that thing with the build variable. Our distro provides no virtualenv. Do you think I can simply rebuild the official package? Does that interfer badly with any other package in my Installation? I guess its fine, yes? |
|
@bors-servo treeclosed- |
|
|
|
@jdm What's the status on that? |
luka-zitnik
added a commit
to luka-zitnik/servo
that referenced
this pull request
Feb 13, 2020
Fixes servo#23210 Closes servo#23212
luka-zitnik
added a commit
to luka-zitnik/servo
that referenced
this pull request
Feb 14, 2020
Fixes servo#23210 Closes servo#23212
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 16, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 18, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 18, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 19, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 19, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 19, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 19, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 19, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 19, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 19, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedApr 16, 2019
•
edited by SimonSapin
This is now a necessary step since #23098.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is