Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow replaying media #23216

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
5 participants
@ferjm
Copy link
Member

commented Apr 16, 2019

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Apr 16, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlmediaelement.rs
  • @KiChjang: components/script/dom/htmlmediaelement.rs
@highfive

This comment has been minimized.

Copy link

commented Apr 16, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@ferjm

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

⌛️ Trying commit eb35896 with merge 1280454...

bors-servo added a commit that referenced this pull request Apr 16, 2019

Auto merge of #23216 - ferjm:replay, r=<try>
Allow replaying media

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23216)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

💔 Test failed - linux-rel-css

@ferjm ferjm force-pushed the ferjm:replay branch from eb35896 to 501e6c1 Apr 17, 2019

@ferjm

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

r? @ceyusa

@highfive highfive assigned ceyusa and unassigned asajeffrey Apr 17, 2019

@ceyusa

This comment has been minimized.

Copy link
Collaborator

commented Apr 17, 2019

lgtm

r+

@ferjm

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

@bors-servo r=ceyusa

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

📌 Commit 501e6c1 has been approved by ceyusa

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

⌛️ Testing commit 501e6c1 with merge 5efd57b...

bors-servo added a commit that referenced this pull request Apr 17, 2019

Auto merge of #23216 - ferjm:replay, r=ceyusa
Allow replaying media

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23216)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

@bors-servo bors-servo merged commit 501e6c1 into servo:master Apr 17, 2019

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.