Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glutin port refactoring #23233

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Projects
None yet
6 participants
@paulrouget
Copy link
Contributor

commented Apr 19, 2019

Glutin port refactoring in preparation for the compositor and libservo refactoring.

In theory, the only behavior change is for headless mode. The headless event loop now uses winit's event loop (but still headless).

Notes:

  • headless and glutin window implementations are now separated
  • I split the methods of the embedder in 2: window specific and general methods. In the future, we still want the app to run even without a window or with multiple windows

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Apr 19, 2019

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/command_base.py, python/servo/testing_commands.py, python/servo/build_commands.py, python/servo/post_build_commands.py
@highfive

This comment has been minimized.

Copy link

commented Apr 19, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@paulrouget

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

bors-servo added a commit that referenced this pull request Apr 19, 2019

Auto merge of #23233 - paulrouget:glutin-port-refactoring, r=<try>
[WIP] Glutin port refactoring

Not ready for review.

Glutin port refactoring in preparation for the compositor and libservo refactoring.

In theory, the only behavior change is for headless mode. The headless event loop now uses winit's event loop (but still headless).

Notes:
- headless and glutin window implementations are now separated
- I split the methods of the embedder in 2: window specific and general methods. In the future, we still want the app to run even without a window or with multiple windows
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

⌛️ Trying commit f738ae9 with merge baf836a...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

💔 Test failed - linux-rel-css

@paulrouget paulrouget force-pushed the paulrouget:glutin-port-refactoring branch from f738ae9 to 05d7006 Apr 19, 2019

@paulrouget

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

⌛️ Trying commit 05d7006 with merge eaaac3f...

bors-servo added a commit that referenced this pull request Apr 19, 2019

Auto merge of #23233 - paulrouget:glutin-port-refactoring, r=<try>
[WIP] Glutin port refactoring

Not ready for review.

Glutin port refactoring in preparation for the compositor and libservo refactoring.

In theory, the only behavior change is for headless mode. The headless event loop now uses winit's event loop (but still headless).

Notes:
- headless and glutin window implementations are now separated
- I split the methods of the embedder in 2: window specific and general methods. In the future, we still want the app to run even without a window or with multiple windows

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23233)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

💔 Test failed - linux-rel-css

@paulrouget

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

⌛️ Trying commit dc6a5a4 with merge ad4ef6a...

bors-servo added a commit that referenced this pull request Apr 19, 2019

Auto merge of #23233 - paulrouget:glutin-port-refactoring, r=<try>
[WIP] Glutin port refactoring

Not ready for review.

Glutin port refactoring in preparation for the compositor and libservo refactoring.

In theory, the only behavior change is for headless mode. The headless event loop now uses winit's event loop (but still headless).

Notes:
- headless and glutin window implementations are now separated
- I split the methods of the embedder in 2: window specific and general methods. In the future, we still want the app to run even without a window or with multiple windows

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23233)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

💔 Test failed - linux-rel-css

@atouchet

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Would you be able to update to the new glutin 0.21 release along with this?

@paulrouget

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

Would you be able to update to the new glutin 0.21 release along with this?

I might do it before this PR. Not sure yet.

@paulrouget

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

the winit event loop on Linux can't work in headless mode :(

@paulrouget

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

⌛️ Trying commit 456b6c1 with merge 3deaf53...

bors-servo added a commit that referenced this pull request Apr 23, 2019

Auto merge of #23233 - paulrouget:glutin-port-refactoring, r=<try>
[WIP] Glutin port refactoring

Not ready for review.

Glutin port refactoring in preparation for the compositor and libservo refactoring.

In theory, the only behavior change is for headless mode. The headless event loop now uses winit's event loop (but still headless).

Notes:
- headless and glutin window implementations are now separated
- I split the methods of the embedder in 2: window specific and general methods. In the future, we still want the app to run even without a window or with multiple windows

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23233)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

💔 Test failed - magicleap

@paulrouget paulrouget force-pushed the paulrouget:glutin-port-refactoring branch from e4ea896 to 21ed765 Apr 29, 2019

@paulrouget

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

Squashed and rebased.

@paulrouget paulrouget referenced this pull request Apr 29, 2019

Merged

Glutin 0.21 #23288

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

📌 Commit 21ed765 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

⌛️ Testing commit 21ed765 with merge a9f7b13...

bors-servo added a commit that referenced this pull request Apr 29, 2019

Auto merge of #23233 - paulrouget:glutin-port-refactoring, r=jdm
Glutin port refactoring

Glutin port refactoring in preparation for the compositor and libservo refactoring.

In theory, the only behavior change is for headless mode. The headless event loop now uses winit's event loop (but still headless).

Notes:
- headless and glutin window implementations are now separated
- I split the methods of the embedder in 2: window specific and general methods. In the future, we still want the app to run even without a window or with multiple windows

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23233)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@bors-servo bors-servo merged commit 21ed765 into servo:master Apr 29, 2019

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@bors-servo bors-servo referenced this pull request Apr 29, 2019

Open

Introduce color-backtrace #23239

3 of 4 tasks complete

bors-servo added a commit that referenced this pull request May 2, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 2, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 3, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 3, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 3, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 6, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 6, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 6, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 9, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 9, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 9, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 21, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 22, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=<try>
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 22, 2019

Auto merge of #23288 - paulrouget:glutin-21, r=jdm
Glutin 0.21

Fix #23189

Depends on #23233

Dependencies update:
- servo/rust-webvr#73
- servo/skia#172
- servo/rust-glx#23
- servo/rust-offscreen-rendering-context#134

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23288)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.