Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webdriver to 0.39 #23234

Merged
merged 1 commit into from Apr 20, 2019
Merged

Update webdriver to 0.39 #23234

merged 1 commit into from Apr 20, 2019

Conversation

@Eijebong
Copy link
Member

Eijebong commented Apr 19, 2019 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Apr 19, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/Cargo.toml, components/webdriver_server/lib.rs
  • @jgraham: components/webdriver_server/Cargo.toml, components/webdriver_server/lib.rs
@jdm
Copy link
Member

jdm commented Apr 19, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2019

📌 Commit 2e040cb has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Apr 19, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2019

⌛ Testing commit 2e040cb with merge fdd44ff...
bors-servo added a commit that referenced this pull request Apr 19, 2019
@bors-servo
Auto merge of #23234 - Eijebong:webdriver, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fdd44ff 
Update webdriver to 0.39

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23234)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2019

💔 Test failed - mac-rel-wpt2
@Eijebong
Copy link
Member Author

Eijebong commented Apr 19, 2019 

{
    "status": "TIMEOUT", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/_webgl/conformance/ogles/GL/asin/asin_001_to_006.html", 
    "line": 52499, 
    "action": "test_result", 
    "expected": "OK"
}

Pretty sure it's unrelated
@jdm
Copy link
Member

jdm commented Apr 19, 2019

@bors-servo retry
bors-servo added a commit that referenced this pull request Apr 19, 2019
@bors-servo
Auto merge of #23234 - Eijebong:webdriver, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5ac6714 
Update webdriver to 0.39

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23234)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2019

⌛ Testing commit 2e040cb with merge 5ac6714...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Apr 20, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2019

⚡ Previous build results for android-mac, arm32, arm64, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster are reusable. Rebuilding only linux-rel-css, linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2019

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Apr 20, 2019

Test failures:

▶ TIMEOUT [expected PASS] /_mozilla/css/img_simple.html 
  ▶ TIMEOUT [expected PASS] /_mozilla/css/per_glyph_font_fallback_a.html

  ▶ TIMEOUT [expected OK] /_mozilla/mozilla/DOMParser.html

  ▶ TIMEOUT [expected OK] /_mozilla/mozilla/secure.https.html
@jdm
Copy link
Member

jdm commented Apr 20, 2019

Fascinating - this update totally breaks the tests that rely on the webdriver server.
@Eijebong Eijebong force-pushed the Eijebong:webdriver branch from 2e040cb to 4c30805 Apr 20, 2019
@Eijebong
Copy link
Member Author

Eijebong commented Apr 20, 2019

Oh, my bad... Should've read the code more carefully :)

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2019

⌛ Trying commit 4c30805 with merge 0e58fb9...
bors-servo added a commit that referenced this pull request Apr 20, 2019
@bors-servo
Auto merge of #23234 - Eijebong:webdriver, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0e58fb9 
Update webdriver to 0.39

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23234)
<!-- Reviewable:end -->
@Eijebong
Update webdriver to 0.39
Loading status checks…
18a90f0
@Eijebong Eijebong force-pushed the Eijebong:webdriver branch from 4c30805 to 18a90f0 Apr 20, 2019
@Eijebong
Copy link
Member Author

Eijebong commented Apr 20, 2019

Yup, that fixed all the servodriver tests
@jdm
Copy link
Member

jdm commented Apr 20, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2019

📌 Commit 18a90f0 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2019

⌛ Testing commit 18a90f0 with merge 3282446...
bors-servo added a commit that referenced this pull request Apr 20, 2019
@bors-servo
Auto merge of #23234 - Eijebong:webdriver, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3282446 
Update webdriver to 0.39

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23234)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 3282446 to master...
@bors-servo bors-servo merged commit 18a90f0 into servo:master Apr 20, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 20, 2019
Merged
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Eijebong @highfive @jdm @bors-servo @nox
You can’t perform that action at this time.