Implement HTMLMediaElement.loop Attribute #23236

swarnimarun · 2019-04-20T15:36:43Z

Work done for Implementing HTMLMediaElement.loop Attribute,

Uncomment loop attribute from webidl
Add make_bool macros for Loop and SetLoop functions
Update the required tests

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #22290

There are tests for these changes

This change is

highfive · 2019-04-20T15:36:49Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.

highfive · 2019-04-20T15:36:50Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs
@KiChjang: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs

swarnimarun · 2019-04-20T15:46:55Z

I am deeply sorry for the late PR.
Currently, there aren't any errors but I am not able to identify what else needs to be done to fix this issue, so that audio_loop_base test runs.

swarnimarun · 2019-04-20T16:02:46Z

Also I didn't know where to mention it but I believe that the Fixme comment here,

servo/components/script/dom/htmlmediaelement.rs

Line 291 in 3282446

// FIXME(nox): Why is this initialised to true?

Refers to the can-autoplay-flag, which seems to be the purpose of autoplaying from it's use,

servo/components/script/dom/htmlmediaelement.rs

Line 1015 in 3282446

self.autoplaying.set(true);

,and should begin with true as per the specs, https://html.spec.whatwg.org/multipage/media.html#can-autoplay-flag.

So it's probably an arbitary comment.

Extremely sorry if it should not be mentioned here.

ferjm

Thanks for the PR! The code looks good, but we need to change the test expectations a little bit before merging it.

I needed to check locally to see why the audio_loop_base.html cause the code looks ok. It appears that we are having troubles reproducing short mp3 files. So I wouldn't worry about it for now. I'll file a follow-up issue to investigate this.

Please, revert the changes done to tests/wpt/metadata/html/semantics/embedded-content/media-elements/audio_loop_base.html.ini and update the test expectations for tests/wpt/metadata/html/dom/interfaces.https.html.ini.

ferjm · 2019-04-22T14:45:42Z

Also I didn't know where to mention it but I believe that the Fixme comment here,

servo/components/script/dom/htmlmediaelement.rs

Line 291 in 3282446
// FIXME(nox): Why is this initialised to true?

Refers to the can-autoplay-flag, which seems to be the purpose of autoplaying from it's use,

servo/components/script/dom/htmlmediaelement.rs

Line 1015 in 3282446
self.autoplaying.set(true);
,and should begin with true as per the specs, https://html.spec.whatwg.org/multipage/media.html#can-autoplay-flag.

So it's probably an arbitary comment.

Extremely sorry if it should not be mentioned here.

No need to apologize :). This is a good place to mention it. A new issue would have also work.

Indeed, it seems that we can remove this comment from the code. This is likely a spec related question instead. cc @nox

Thanks for raising up the issue.

ferjm · 2019-04-22T14:52:25Z

I needed to check locally to see why the audio_loop_base.html cause the code looks ok. It appears that we are having troubles reproducing short mp3 files. So I wouldn't worry about it for now. I'll file a follow-up issue to investigate this.

I filed #23241

swarnimarun · 2019-04-22T19:15:57Z

Ok thanks. Will fix up the tests ASAP.


        Implement HTMLMediaElement.loop Attribute


        Update video loop and interface https tests

swarnimarun · 2019-04-26T19:44:40Z

Please, revert the changes done to tests/wpt/metadata/html/semantics/embedded-content/media-elements/audio_loop_base.html.ini and update the test expectations for tests/wpt/metadata/html/dom/interfaces.https.html.ini.

Rebased and updated the test expectations for HTMLMediaElement in interfaces.https

ferjm · 2019-04-29T07:51:37Z

@bors-servo try=wpt

bors-servo · 2019-04-29T07:51:42Z

⌛ Trying commit 4383f4d with merge 401b437...


        Auto merge of #23236 - swarnimarun:loop_patch, r=<try>

[WIP] Implement HTMLMediaElement.loop Attribute  Work done for Implementing HTMLMediaElement.loop Attribute, - Uncomment `loop` attribute from webidl - Add make_bool macros for Loop and SetLoop functions - Update the required tests ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22290  - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23236)

bors-servo · 2019-04-29T08:22:41Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

ferjm · 2019-04-29T08:31:40Z

Thanks!

@bors-servo r+

bors-servo · 2019-04-29T08:31:40Z

📋 Looks like this PR is still in progress, ignoring approval

ferjm · 2019-04-29T09:29:01Z

@bors-servo r+

bors-servo · 2019-04-29T09:29:02Z

📌 Commit 4383f4d has been approved by ferjm

bors-servo · 2019-04-29T09:29:07Z

⌛ Testing commit 4383f4d with merge 44bd09d...


        Auto merge of #23236 - swarnimarun:loop_patch, r=ferjm

Implement HTMLMediaElement.loop Attribute  Work done for Implementing HTMLMediaElement.loop Attribute, - Uncomment `loop` attribute from webidl - Add make_bool macros for Loop and SetLoop functions - Update the required tests ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22290  - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23236)

bors-servo · 2019-04-29T10:56:35Z

💔 Test failed - status-taskcluster

CYBAI · 2019-04-29T11:34:16Z

@bors-servo retry

  ▶ FAIL [expected PASS] /css/CSS2/syntax/at-charset-042.xht
  └   → /css/CSS2/syntax/at-charset-042.xht 142a99007818eaad451b21601c1bfd04e79e8486
/css/CSS2/syntax/at-charset-001-ref.xht 0c2e5215e1346ac2422396dc1d3ca7f950906e29

bors-servo · 2019-04-29T11:34:19Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2019-04-29T11:34:26Z

⌛ Testing commit 4383f4d with merge 172736a...


        Auto merge of #23236 - swarnimarun:loop_patch, r=ferjm

Implement HTMLMediaElement.loop Attribute  Work done for Implementing HTMLMediaElement.loop Attribute, - Uncomment `loop` attribute from webidl - Add make_bool macros for Loop and SetLoop functions - Update the required tests ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22290  - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23236)

bors-servo · 2019-04-29T12:38:45Z

💔 Test failed - mac-rel-wpt2

jdm · 2019-04-29T14:56:28Z

@bors-servo retry

bors-servo · 2019-04-29T16:20:45Z

⌛ Testing commit 4383f4d with merge 67beaa4...


        Auto merge of #23236 - swarnimarun:loop_patch, r=ferjm

Implement HTMLMediaElement.loop Attribute  Work done for Implementing HTMLMediaElement.loop Attribute, - Uncomment `loop` attribute from webidl - Add make_bool macros for Loop and SetLoop functions - Update the required tests ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22290  - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23236)

bors-servo · 2019-04-29T17:59:00Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: ferjm
Pushing 67beaa4 to master...

atouchet · 2019-05-01T02:36:42Z

Aren't the passing tests supposed to be removed?

CYBAI · 2019-05-01T04:19:22Z

Aren't the passing tests supposed to be removed?

They will be removed in next Sync WPT PR :)

atouchet · 2019-05-30T06:02:26Z

They will be removed in next Sync WPT PR :)

It doesn't look like they were.


        Auto merge of #23480 - atouchet:tests, r=ferjm

Update test expectations  Some of these tests are passing as of #23236. Were these supposed to be removed? ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23480)


        Auto merge of #23480 - atouchet:tests, r=ferjm

Update test expectations  Some of these tests are passing as of #23236. Were these supposed to be removed? ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23480)

highfive assigned SimonSapin Apr 20, 2019

highfive added the S-awaiting-review label Apr 20, 2019

ferjm requested changes Apr 22, 2019

View changes

swarnimarun added 2 commits Apr 20, 2019

Implement HTMLMediaElement.loop Attribute

3bf3a78

Update video loop and interface https tests

Loading status checks…

4383f4d

swarnimarun force-pushed the swarnimarun:loop_patch branch from a70e2ea to 4383f4d Apr 26, 2019

highfive assigned ferjm and unassigned SimonSapin Apr 29, 2019

ferjm changed the title ~~[WIP] Implement HTMLMediaElement.loop Attribute~~ Implement HTMLMediaElement.loop Attribute Apr 29, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 29, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 29, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 29, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 29, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 29, 2019

highfive removed the S-awaiting-merge label Apr 29, 2019

atouchet mentioned this pull request May 30, 2019

Update test expectations #23480

Merged

0 of 5 tasks complete

servo / servo

Implement HTMLMediaElement.loop Attribute #23236

Implement HTMLMediaElement.loop Attribute #23236

swarnimarun commented Apr 20, 2019 •

edited by ferjm

highfive commented Apr 20, 2019

highfive commented Apr 20, 2019

swarnimarun commented Apr 20, 2019

swarnimarun commented Apr 20, 2019

ferjm left a comment

ferjm commented Apr 22, 2019 •

edited

ferjm commented Apr 22, 2019

swarnimarun commented Apr 22, 2019

swarnimarun commented Apr 26, 2019

ferjm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

ferjm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

ferjm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

CYBAI commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

jdm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

atouchet commented May 1, 2019

CYBAI commented May 1, 2019

atouchet commented May 30, 2019

servo / servo

Join GitHub today

Implement HTMLMediaElement.loop Attribute #23236

Implement HTMLMediaElement.loop Attribute #23236

Conversation

swarnimarun commented Apr 20, 2019 • edited by ferjm

highfive commented Apr 20, 2019

highfive commented Apr 20, 2019

swarnimarun commented Apr 20, 2019

swarnimarun commented Apr 20, 2019

ferjm left a comment

ferjm commented Apr 22, 2019 • edited

ferjm commented Apr 22, 2019

swarnimarun commented Apr 22, 2019

swarnimarun commented Apr 26, 2019

ferjm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

ferjm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

ferjm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

CYBAI commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

jdm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

atouchet commented May 1, 2019

CYBAI commented May 1, 2019

atouchet commented May 30, 2019

swarnimarun commented Apr 20, 2019 •

edited by ferjm

ferjm commented Apr 22, 2019 •

edited