Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded liblzma-dev dependency on Debian #23248
Merged
Conversation
|
Could you update servo/python/servo/bootstrap.py Line 110 in 54f54d1 |
|
Done. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 23, 2019
Added liblzma-dev dependency on Debian
<!-- Please describe your changes on the following line: -->
This fixes a link error on Debian Linux
```
= note: /usr/bin/ld.gold: error: cannot find -llzma
collect2: error: ld returned 1 exit status
```
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's a README
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23248)
<!-- Reviewable:end -->
|
|
|
One of the taskcluster Mac runs timed out: @bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 24, 2019
Added liblzma-dev dependency on Debian
<!-- Please describe your changes on the following line: -->
This fixes a link error on Debian Linux
```
= note: /usr/bin/ld.gold: error: cannot find -llzma
collect2: error: ld returned 1 exit status
```
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's a README
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23248)
<!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedApr 23, 2019
•
edited by SimonSapin
This fixes a link error on Debian Linux
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is