Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake for MSVC builds. #23254

Closed
wants to merge 2 commits into from
Closed

Update cmake for MSVC builds. #23254

wants to merge 2 commits into from

Conversation

@jdm
Copy link
Member

jdm commented Apr 24, 2019 •
edited by SimonSapin

This is required for making builds with clang-cl instead of MSVC's cl.

This change is Reviewable
@jdm
Update cmake for MSVC builds.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
817aa49
@highfive
Copy link

highfive commented Apr 24, 2019

Heads up! This PR modifies the following files:
@jdm
tmp
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
06f187b
@jdm
Copy link
Member Author

jdm commented Apr 24, 2019

This will happen as part of #23256.
@jdm jdm closed this Apr 24, 2019
@jdm jdm deleted the jdm-patch-37 branch Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jdm @highfive @SimonSapin
You can’t perform that action at this time.