Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clang-cl for Windows builds #23256

Merged
merged 3 commits into from Apr 25, 2019

Conversation

Projects
None yet
5 participants
@jdm
Copy link
Member

commented Apr 24, 2019

Depends on servo/mozjs#178.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Apr 24, 2019

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

Copy link

commented Apr 24, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@jdm jdm changed the title Use clang-cl for Windows builds [WIP] Use clang-cl for Windows builds Apr 24, 2019

@jdm jdm force-pushed the jdm:clang-cl branch from 4827df0 to c1c9799 Apr 24, 2019

@jdm

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

@bors-servo try=windows

bors-servo added a commit that referenced this pull request Apr 25, 2019

Auto merge of #23256 - jdm:clang-cl, r=<try>
[WIP] Use clang-cl for Windows builds

Depends on servo/mozjs#178.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23256)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

⌛️ Trying commit 57cbc61 with merge 23767f8...

@jdm jdm force-pushed the jdm:clang-cl branch from 57cbc61 to 5331a98 Apr 25, 2019

@jdm jdm force-pushed the jdm:clang-cl branch from 5331a98 to 0136e5a Apr 25, 2019

@jdm jdm changed the title [WIP] Use clang-cl for Windows builds Use clang-cl for Windows builds Apr 25, 2019

@jdm

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

@jdm

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

This passed appveyor and taskcluster without any issues, which was a delightful surprise.

@asajeffrey

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

LGTM, you can r=me, or wait until someone with a windows machine can test it.

@jdm

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

I tested this on my windows laptop and it worked better than the MSVC build, since that one could not actually complete \o/

@bors-servo r=asajeffrey

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

📌 Commit 0136e5a has been approved by asajeffrey

@highfive highfive assigned asajeffrey and unassigned paulrouget Apr 25, 2019

bors-servo added a commit that referenced this pull request Apr 25, 2019

Auto merge of #23256 - jdm:clang-cl, r=asajeffrey
Use clang-cl for Windows builds

Depends on servo/mozjs#178.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23256)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

⌛️ Testing commit 0136e5a with merge 36bb425...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

@bors-servo bors-servo merged commit 0136e5a into servo:master Apr 25, 2019

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

bors-servo added a commit that referenced this pull request Apr 26, 2019

Auto merge of #23275 - servo:jdm-patch-37, r=Manishearth
Use llvm's linker for x86 builds.

This is a follow up to #23256 and #23211.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23275)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request Apr 26, 2019

Auto merge of #23275 - servo:jdm-patch-37, r=Manishearth
Use llvm's linker for x86 builds.

This is a follow up to #23256 and #23211.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23275)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request Apr 27, 2019

Auto merge of #23275 - servo:jdm-patch-37, r=Manishearth
Use llvm's linker for x86 builds.

This is a follow up to #23256 and #23211.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23275)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.