Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AudioParam.setValueCurveAtTime #22897 #23259

Merged
merged 1 commit into from Apr 27, 2019
+220 −14
Merged

Implement AudioParam.setValueCurveAtTime #22897 #23259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Loading status checks…

Implemented JS API for setValueCurveAtTime and updated tests

  • Loading branch information
@Akhilesh1996
Akhilesh1996 committed Apr 27, 2019
commit b519a0b941a20ae4e0e0c4214c57001074d8a47d
34 components/script/dom/audioparam.rs
View file
Open in desktop
@@ -231,6 +231,40 @@ impl AudioParamMethods for AudioParam {
Ok(DomRoot::from_ref(self))
}

// https://webaudio.github.io/web-audio-api/#dom-audioparam-setvaluecurveattime
fn SetValueCurveAtTime(
&self,
values: Vec<Finite<f32>>,
start_time: Finite<f64>,
end_time: Finite<f64>,
) -> Fallible<DomRoot<AudioParam>> {
if *start_time < 0. {
return Err(Error::Range(format!(
"start time {} should not be negative",
*start_time
)));
}
if values.len() < 2. as usize {
return Err(Error::InvalidState);
}

if *end_time < 0. {
return Err(Error::Range(format!(
"end time {} should not be negative",
*end_time
)));
}
self.message_node(AudioNodeMessage::SetParam(

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Apr 25, 2019

Member

This needs to do a bunch of input validation, see the "description" column of the arguments table on https://webaudio.github.io/web-audio-api/#dom-audioparam-setvaluecurveattime

This comment has been minimized.

Sign in to view
Copy link
@Akhilesh1996

Akhilesh1996 Apr 25, 2019

Author Contributor

For this, I based my code on the other processing algorithms that are already present in AudioParam.rs because they had the same kind of validation description. Can you give me some pointers or some example that I can look into so that I can fix the same?

Thanks.

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Apr 25, 2019

Member

You can see examples of such checks on https://github.com/ferjm/servo/blob/webaudio/components/script/dom/audionode.rs#L100

(Looks like the other AudioParam functions are missing validation too, I should add that)

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Apr 25, 2019

Member

You can see examples of such checks on https://github.com/ferjm/servo/blob/webaudio/components/script/dom/audionode.rs#L100

(Looks like the other AudioParam functions are missing validation too, I should add that)

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Apr 25, 2019

Member

do the same thing done in #23270

This comment has been minimized.

Sign in to view
Copy link
@Akhilesh1996

Akhilesh1996 Apr 25, 2019

Author Contributor

I have added the validations and pushed the code.

Thanks.

This comment has been minimized.

Sign in to view
Copy link
@Akhilesh1996

Akhilesh1996 Apr 26, 2019

Author Contributor

I think I have corrected the error, can you take a look now?
self.param,
UserAutomationEvent::SetValueCurveAtTime(
values.into_iter().map(|v| *v).collect(),
*start_time,
*end_time,
),
));
Ok(DomRoot::from_ref(self))
}

// https://webaudio.github.io/web-audio-api/#dom-audioparam-cancelscheduledvalues
fn CancelScheduledValues(&self, cancel_time: Finite<f64>) -> Fallible<DomRoot<AudioParam>> {
if *cancel_time < 0. {
6 components/script/dom/webidls/AudioParam.webidl
View file
Open in desktop
@@ -24,9 +24,9 @@ interface AudioParam {
[Throws] AudioParam setTargetAtTime(float target,
double startTime,
float timeConstant);
// AudioParam setValueCurveAtTime(sequence<float> values,
// double startTime,
// double duration);
[Throws] AudioParam setValueCurveAtTime(sequence<float> values,
double startTime,
double duration);
[Throws] AudioParam cancelScheduledValues(double cancelTime);
[Throws] AudioParam cancelAndHoldAtTime(double cancelTime);
};
9 tests/wpt/metadata/webaudio/idlharness.https.window.js.ini
View file
Open in desktop
@@ -752,9 +752,6 @@
[AudioNode interface: new MediaElementAudioSourceNode(context, {mediaElement: new Audio}) must inherit property "channelInterpretation" with the proper type]
expected: FAIL
[AudioParam interface: operation setValueCurveAtTime([object Object\], double, double)]
expected: FAIL
[BaseAudioContext interface: operation createIIRFilter([object Object\], [object Object\])]
expected: FAIL
@@ -1253,9 +1250,6 @@
[IIRFilterNode interface: existence and properties of interface object]
expected: FAIL

[AudioParam interface: calling setValueCurveAtTime([object Object\], double, double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError]
expected: FAIL

[OfflineAudioContext interface: operation startRendering()]
expected: FAIL

@@ -1472,9 +1466,6 @@
[AudioNode interface: calling disconnect(AudioParam) on worklet_node with too few arguments must throw TypeError]
expected: FAIL

[AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "setValueCurveAtTime([object Object\], double, double)" with the proper type]
expected: FAIL

[AudioNode interface: context.createScriptProcessor() must inherit property "disconnect(AudioNode, unsigned long, unsigned long)" with the proper type]
expected: FAIL

18 ...ta/webaudio/the-audio-api/the-audioparam-interface/audioparam-exceptional-values.html.ini
View file
Open in desktop
@@ -17,3 +17,21 @@
[# AUDIT TASK RUNNER FINISHED: 1 out of 6 tasks were failed.]
expected: FAIL

[X gain.gain.setValueCurveAtTime([0,0,0\],-1,1) did not throw an exception.]
expected: FAIL

[X gain.gain.setValueCurveAtTime(curve, 1, -1) did not throw an exception.]
expected: FAIL

[X gain.gain.setValueCurveAtTime([0,0,0\],1,-1) did not throw an exception.]
expected: FAIL

[X gain.gain.setValueCurveAtTime(curve, 1, 0) did not throw an exception.]
expected: FAIL

[< [special cases 1\] 6 out of 9 assertions were failed.]
expected: FAIL

[< [special cases 1\] 1 out of 9 assertions were failed.]
expected: FAIL

28 ...adata/webaudio/the-audio-api/the-audioparam-interface/audioparam-method-chaining.html.ini
View file
Open in desktop
@@ -1,2 +1,28 @@
[audioparam-method-chaining.html]
expected: ERROR
[< [invalid-operation\] 4 out of 4 assertions were failed.]
expected: FAIL

[X The gain value of the second gain node is not equal to 0.5. Got 0.]
expected: FAIL

[# AUDIT TASK RUNNER FINISHED: 2 out of 3 tasks were failed.]
expected: FAIL

[< [verification\] 1 out of 1 assertions were failed.]
expected: FAIL

[X Calling setValueAtTime() with a negative end time did not throw an exception.]
expected: FAIL

[X Calling exponentialRampToValueAtTime() with a zero target value did not throw an exception.]
expected: FAIL

[X The gain value of the first gain node is not equal to 1. Got 2.]
expected: FAIL

[X The rendered envelope does not equal [0,0.000125,0.00025,0.000375,0.0005,0.000625,0.00075,0.000875,0.001,0.001125,0.00125,0.001375,0.0015,0.001625,0.00175,0.001875...\] with an element-wise tolerance of {"absoluteThreshold":0.0000040532,"relativeThreshold":0}.\n\tIndex\tActual\t\t\tExpected\t\tAbsError\t\tRelError\t\tTest threshold\n\t[1\]\t0.0000000000000000e+0\t1.2500000000000000e-4\t1.2500000000000000e-4\t1.0000000000000000e+0\t4.0531999999999996e-6\n\t[2\]\t0.0000000000000000e+0\t2.5000000000000001e-4\t2.5000000000000001e-4\t1.0000000000000000e+0\t4.0531999999999996e-6\n\t[3\]\t0.0000000000000000e+0\t3.7500000000000001e-4\t3.7500000000000001e-4\t1.0000000000000000e+0\t4.0531999999999996e-6\n\t[4\]\t0.0000000000000000e+0\t5.0000000000000001e-4\t5.0000000000000001e-4\t1.0000000000000000e+0\t4.0531999999999996e-6\n\t[5\]\t0.0000000000000000e+0\t6.2500000000000001e-4\t6.2500000000000001e-4\t1.0000000000000000e+0\t4.0531999999999996e-6\n\t...and 31994 more errors.\n\tMax AbsError of 1.0000000000000000e+0 at index of 8000.\n\t[8000\]\t0.0000000000000000e+0\t1.0000000000000000e+0\t1.0000000000000000e+0\t1.0000000000000000e+0\t4.0531999999999996e-6\n\tMax RelError of 1.0000000000000000e+0 at index of 1.\n]
expected: FAIL

[# AUDIT TASK RUNNER FINISHED: 1 out of 3 tasks were failed.]
expected: FAIL

15 ...audio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions.html.ini
View file
Open in desktop
@@ -33,3 +33,18 @@
[X exponentialRampToValueAtTime(1, 0.018750000000000003) did not throw an exception.]
expected: FAIL

[X setValueCurveAtTime(curve, 0.043750000000000004, 0.01) did not throw an exception.]
expected: FAIL

[< [setValueCurve\] 4 out of 6 assertions were failed.]
expected: FAIL

[X setValueCurveAtTime(curve, 0.018750000000000003, 0.01) did not throw an exception.]
expected: FAIL

[X setValueCurveAtTime(curve, 0.00625, 0.01) did not throw an exception.]
expected: FAIL

[X setValueCurveAtTime(curve, 0.03125, 0.01) did not throw an exception.]
expected: FAIL

124 ...a/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurveAtTime.html.ini
View file
Open in desktop
@@ -1,2 +1,124 @@
[audioparam-setValueCurveAtTime.html]
expected: ERROR
[X Max error for test 12 at offset 15876 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Apr 25, 2019

Member

Most of these tests shouldn't be failing. Are you sure the servo-media code is doing the right thing?

This comment has been minimized.

Sign in to view
Copy link
@Akhilesh1996

Akhilesh1996 Apr 25, 2019

Author Contributor

I was also confused about the same. We get the expected output while running the code from the servo/media directory as I printed out the values and time to verify. But I got similar amount of failures when I ran the tests for linearRampToValueAtTime, exponentialRampToValueAtTime etc so I thought this was common.

I also noticed that a lot of error were of the following type:
[X Discontinuity at index is not equal to 7938. Got 7940.]
expected: FAIL

[X Discontinuity at index is not equal to 6615. Got 6617.]
expected: FAIL

[X Discontinuity at index is not equal to 11907. Got 11909.]
expected: FAIL

[X Discontinuity at index is not equal to 9261. Got 9263.]
expected: FAIL
There is a mismatch by 2 for all of these.

Is there somewhere I can look to fix these or is this something I don't have to look into?

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Apr 25, 2019

Member

This could be a timing synchronization bug which wouldn't be your fault.

You're right that most seem minor, though the Max error ones don't seem so minor.

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Apr 25, 2019

Member

Filed #23271, ignore this issue for now.

[X Discontinuity at index is not equal to 1323. Got 1325.]
expected: FAIL

[X Max error for test 15 at offset 19845 is not less than or equal to 0.0000037194. Got 0.464914441108627.]
expected: FAIL

[X Max error for test 19 at offset 25137 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Max error for test 17 at offset 22491 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Discontinuity at index is not equal to 7938. Got 7940.]
expected: FAIL

[X Discontinuity at index is not equal to 6615. Got 6617.]
expected: FAIL

[X Discontinuity at index is not equal to 11907. Got 11909.]
expected: FAIL

[X Discontinuity at index is not equal to 9261. Got 9263.]
expected: FAIL

[X Discontinuity at index is not equal to 3969. Got 3971.]
expected: FAIL

[X Discontinuity at index is not equal to 23814. Got 23816.]
expected: FAIL

[X Discontinuity at index is not equal to 22491. Got 22493.]
expected: FAIL

[X Max error for test 14 at offset 18522 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Discontinuity at index is not equal to 17199. Got 17201.]
expected: FAIL

[X Number of discontinuites at incorrect locations is not equal to 0. Got 19.]
expected: FAIL

[X Max error for test 11 at offset 14553 is not less than or equal to 0.0000037194. Got 0.464914441108627.]
expected: FAIL

[X Max error for test 4 at offset 5292 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Max error for test 13 at offset 17199 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Max error for test 2 at offset 2646 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Max error for test 18 at offset 23814 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[< [test\] 39 out of 41 assertions were failed.]
expected: FAIL

[X Max error for test 6 at offset 7938 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Discontinuity at index is not equal to 21168. Got 21170.]
expected: FAIL

[X Max error for test 10 at offset 13230 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Discontinuity at index is not equal to 5292. Got 5294.]
expected: FAIL

[X Max error for test 3 at offset 3969 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Discontinuity at index is not equal to 19845. Got 19847.]
expected: FAIL

[X Max error for test 7 at offset 9261 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Discontinuity at index is not equal to 2646. Got 2648.]
expected: FAIL

[X Max error for test 1 at offset 1323 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Discontinuity at index is not equal to 18522. Got 18524.]
expected: FAIL

[X Discontinuity at index is not equal to 10584. Got 10586.]
expected: FAIL

[# AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed.]
expected: FAIL

[X Discontinuity at index is not equal to 25137. Got 25139.]
expected: FAIL

[X Discontinuity at index is not equal to 14553. Got 14555.]
expected: FAIL

[X Discontinuity at index is not equal to 15876. Got 15878.]
expected: FAIL

[X Max error for test 8 at offset 10584 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Max error for test 16 at offset 21168 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Max error for test 5 at offset 6615 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Max error for test 9 at offset 11907 is not less than or equal to 0.0000037194. Got 0.4649144411087036.]
expected: FAIL

[X Discontinuity at index is not equal to 13230. Got 13232.]
expected: FAIL

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.