Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ChildNode.remove() #2326

Merged
merged 1 commit into from May 5, 2014
Merged

Implement ChildNode.remove() #2326

merged 1 commit into from May 5, 2014

Conversation

@jdm
Copy link
Member

jdm commented May 5, 2014

Fixes #2191.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 5, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1461

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm jdm mentioned this pull request May 5, 2014
Closed
@hmac @jdm
Implement ChildNode.remove()
Loading status checks…
6f310a5
@Ms2ger

This comment has been minimized.

Sign in to view
Copy link
Collaborator

Ms2ger commented on 6f310a5 May 5, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 6f310a5 May 5, 2014

saw approval from Ms2ger
at jdm@6f310a5

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 5, 2014

merging jdm/servo/remove = 6f310a5 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 5, 2014

jdm/servo/remove = 6f310a5 merged ok, testing candidate = 2da560e

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 5, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/1342
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1296

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied May 5, 2014

fast-forwarding master to auto = 2da560e
bors-servo pushed a commit that referenced this pull request May 5, 2014
bors-servo
auto merge of #2326 : jdm/servo/remove, r=Ms2ger
2da560e 
Fixes #2191.
@bors-servo bors-servo merged commit 6f310a5 into servo:master May 5, 2014
1 check passed
1 check passed
default all tests passed
@jdm jdm deleted the jdm:remove branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement ChildNode.remove()
5 participants
@jdm @hoppipolla-critic-bot @bors-servo @Ms2ger @hmac
You can’t perform that action at this time.