Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to rustc 1.36.0-nightly (e305df184 2019-04-24) #23263
Merged
+22
−22
Conversation
This includes a `size_of` regression for a few DOM types, due to rust-lang/rust#58623 which replaces the implementation of `HashMap` in the standard library to Hashbrown. Although `size_of<HashMap>` grows, it’s not obvious how total memory usage is going to be impacted: Hashbrown only has one `u8` instead of one `usize` of overhead per hash table bucket for storing (part of) a hash, and so might allocate less memory itself. Hashbrown also typically has better run time performance: https://github.com/rust-lang/hashbrown#performance Still, I’ve filed rust-lang/hashbrown#69 about potentially reducing the `size_of<HashMap>` regression.
|
We could also replace this servo/components/script/dom/eventtarget.rs Line 326 in 07d1559 |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 25, 2019
Upgrade to rustc 1.36.0-nightly (e305df184 2019-04-24) This includes a `size_of` regression for a few DOM types, due to rust-lang/rust#58623 which replaces the implementation of `HashMap` in the standard library to Hashbrown. Although `size_of<HashMap>` grows, it’s not obvious how total memory usage is going to be impacted: Hashbrown only has one `u8` instead of one `usize` of overhead per hash table bucket for storing (part of) a hash, and so might allocate less memory itself. Hashbrown also typically has better run time performance: https://github.com/rust-lang/hashbrown#performance Still, I’ve filed rust-lang/hashbrown#69 about potentially reducing the `size_of<HashMap>` regression. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23263) <!-- Reviewable:end -->
|
|
This was referenced Apr 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedApr 25, 2019
•
edited
This includes a
size_ofregression for a few DOM types, due to rust-lang/rust#58623 which replaces the implementation ofHashMapin the standard library to Hashbrown.Although
size_of<HashMap>grows, it’s not obvious how total memory usage is going to be impacted: Hashbrown only has oneu8instead of oneusizeof overhead per hash table bucket for storing (part of) a hash, and so might allocate less memory itself.Hashbrown also typically has better run time performance: https://github.com/rust-lang/hashbrown#performance
Still, I’ve filed rust-lang/hashbrown#69 about potentially reducing the
size_of<HashMap>regression.This change is