Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.36.0-nightly (e305df184 2019-04-24) #23263

Merged
merged 1 commit into from Apr 25, 2019
Merged

Upgrade to rustc 1.36.0-nightly (e305df184 2019-04-24) #23263

merged 1 commit into from Apr 25, 2019

Commits on Apr 25, 2019

  1. Upgrade to rustc 1.36.0-nightly (e305df184 2019-04-24)

    This includes a `size_of` regression for a few DOM types,
    due to rust-lang/rust#58623 which replaces the
    implementation of `HashMap` in the standard library to Hashbrown.
    
    Although `size_of<HashMap>` grows, it’s not obvious how total memory usage
    is going to be impacted: Hashbrown only has one `u8` instead of one `usize`
    of overhead per hash table bucket for storing (part of) a hash,
    and so might allocate less memory itself.
    
    Hashbrown also typically has better run time performance:
    https://github.com/rust-lang/hashbrown#performance
    
    Still, I’ve filed rust-lang/hashbrown#69
    about potentially reducing the `size_of<HashMap>` regression.
    SimonSapin committed Apr 25, 2019
You can’t perform that action at this time.