Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd input validation for AudioParam methods #23270
Merged
Conversation
highfive
commented
Apr 25, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 25, 2019
|
|
Manishearth
force-pushed the
Manishearth:audioparam-validation
branch
2 times, most recently
from
3968701
to
afb92d3
Manishearth
force-pushed the
Manishearth:audioparam-validation
branch
from
afb92d3
to
8a8a9f7
|
r? @ferjm |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 26, 2019
Add input validation for AudioParam methods Waiting on a build to make WPT updates Spec requires us to validate inputs, we aren't doing this here. We don't need to check for things being finite since we already get the arguments as `Finite` values <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23270) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedApr 25, 2019
•
edited by SimonSapin
Waiting on a build to make WPT updates
Spec requires us to validate inputs, we aren't doing this here.
We don't need to check for things being finite since we already get the arguments as
FinitevaluesThis change is