Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
ISSUE-20455: introduce stronger types for textinput indexing #23272
Added two new types:
I've replaced any instance of
I did not end up finding any places where types were very obviously being mixed, as the issue description suggested I should do... LMK if I should re-audit the file for that (might need a bit of guidance)!
Heads up! This PR modifies the following files:
referenced this pull request
May 15, 2019
No. Now that an amended commit has been pushed, as far as I know it can’t easily be undone.
What I meant is that, when a reviewer asks for changes one a large PR, it’s preferable to avoid using
But don’t worry about it for this PR, I’ll manage :)