Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StereoPannerNode DOM #23281

Merged
merged 2 commits into from May 1, 2019

Conversation

Projects
None yet
6 participants
@PurpleHairEngineer
Copy link
Contributor

commented Apr 27, 2019

This is the DOM implementation for StereoPannerNode. Backend implemented in servo/media#243.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Apr 27, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

commented Apr 27, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/baseaudiocontext.rs, components/script/dom/mod.rs, components/script/dom/stereopannernode.rs, components/script/dom/webidls/BaseAudioContext.webidl, components/script/dom/webidls/StereoPannerNode.webidl
  • @KiChjang: components/script/dom/baseaudiocontext.rs, components/script/dom/mod.rs, components/script/dom/stereopannernode.rs, components/script/dom/webidls/BaseAudioContext.webidl, components/script/dom/webidls/StereoPannerNode.webidl
@highfive

This comment has been minimized.

Copy link

commented Apr 27, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

@highfive highfive assigned Manishearth and unassigned SimonSapin Apr 27, 2019

@PurpleHairEngineer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

@Manishearth Okay, I believe I added the constraints appropriately. Thank you.

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

☔️ The latest upstream changes (presumably #22743) made this pull request unmergeable. Please resolve the merge conflicts.

@PurpleHairEngineer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@Manishearth I see that there are build errors for this, but a lot of them seem to be related to the fact that it can't find stereo_panner_node in servo_media. That's being implemented in a different pull request, servo/media#243 . Is there anything else I can do for this one before I get that one working?

@Manishearth

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Nah, get that one working first. There's a way to locally redirect dependencies but I'd rather just merge that first and look at this one later.

@PurpleHairEngineer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

@Manishearth Now that servo/media#243 has been merged, what is the best way to update this branch to reflect those changes? Should I pull the master branch, or something else?

@Manishearth

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

./mach cargo update -p servo-media should be enough. Commit the changes it causes.

Also, you should first rebase and squash this (there will be a small merge conflict that needs fixing) so you won't have the same problem you had in the other PR.

Ideally if you can, make the commit that updates servo-media a separate commit before the main one (it's easier to rebase this in case of lockfile issues), but don't worry about that if you don't know how.

@PurpleHairEngineer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

@Manishearth Are you saying I should squash before running the /mach cargo update -p servo-media command? When I tried to run git rebase -i HEAD~5, it showed my commits at the top and then almost 400 commits after that. Are you saying I should squash them all?

@Manishearth

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

git rebase -i HEAD~5

Run git fetch origin and then git rebase -i origin/master. Only squash your commits, no other commits should show up. I can do it for you if you need.

Yes, squash first.

@PurpleHairEngineer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

@Manishearth I ran git rebase -i origin/master, but in the editor, it is showing my 4 commits on top followed by about 390 others. What should I do? I don't want to close the editor because I know it does the rebasing even if I close it without making any changes.

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

If you remove all of the entries and close the editor, the rebase will be cancelled without making any changes.

@PurpleHairEngineer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

@jdm Thanks for the tip! Sorry, I don't have a lot of experience using git before this project.

@Manishearth

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

On a bus right now, will push later. Is origin the servo repo or your fork? If it's your fork, do git remote add upstream https://github.com/servo/servo.git and then use git rebase -i upstream/master.

This worked for me locally.

@PurpleHairEngineer PurpleHairEngineer force-pushed the josephhutch:StereoPannerNode branch from c07ce26 to 0e6f850 Apr 30, 2019

@PurpleHairEngineer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

@Manishearth origin is the fork (https://github.com/josephhutch/servo). Thanks! I had to run git fetch in between those two commands, but I think it worked!

@Manishearth Manishearth force-pushed the josephhutch:StereoPannerNode branch from 0e6f850 to a7e132f Apr 30, 2019

@Manishearth Manishearth force-pushed the josephhutch:StereoPannerNode branch from a7e132f to e5b7cc7 Apr 30, 2019

@Manishearth

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Pushed. I also included the update of servo-media.

Run the following to get the update locally

git fetch origin
git checkout origin/StereoPannerNode
git checkout -B StereoPannerNode
git push origin StereoPannerNode -u
@PurpleHairEngineer

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

@Manishearth I'm getting the following build error:

error[E0599]: no variant or associated item named `StereoPannerNode` found for type `dom::bindings::codegen::InheritTypes::AudioNodeTypeId` in the current scope
   --> components\script\dom\audionode.rs:288:59
    |
288 |             EventTargetTypeId::AudioNode(AudioNodeTypeId::StereoPannerNode) => {
    |                                                           ^^^^^^^^^^^^^^^^ variant or associated item not found in `dom::bindings::codegen::InheritTypes::AudioNodeTypeId`

I've searched the repo for AudioNodeTypeId, but I can't figure out where I need to add StereoPannerNode in order to get rid of this error?

@Manishearth
Copy link
Member

left a comment

this gets subclassed twice, so the type id is a bit more complex

Show resolved Hide resolved components/script/dom/audionode.rs Outdated
Show resolved Hide resolved components/script/dom/audionode.rs Outdated
@Manishearth

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

📌 Commit e22c005 has been approved by Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

⌛️ Testing commit e22c005 with merge 4d5f4b8...

bors-servo added a commit that referenced this pull request Apr 30, 2019

Auto merge of #23281 - josephhutch:StereoPannerNode, r=Manishearth
StereoPannerNode DOM

<!-- Please describe your changes on the following line: -->

This is the DOM implementation for StereoPannerNode. Backend implemented in servo/media#243.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23281)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

💔 Test failed - linux-rel-wpt

@Manishearth Manishearth force-pushed the josephhutch:StereoPannerNode branch from e22c005 to 58f0274 Apr 30, 2019

@Manishearth

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@bors r+

@PurpleHairEngineer

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

@Manishearth Thank you so much for all your help! It looks like you approved the merge but it is still open. Is there anything else I can do for this?

@Manishearth

This comment has been minimized.

Copy link
Member

commented May 1, 2019

No, our CI robot will eventually test and merge this

@PurpleHairEngineer

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

@Manishearth Oh okay, I was just wondering because it has the label awaiting review.

@Manishearth

This comment has been minimized.

Copy link
Member

commented May 1, 2019

@bors-servo r+

ah, did it the wrong way

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

📌 Commit 58f0274 has been approved by Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

⌛️ Testing commit 58f0274 with merge aa63d60...

bors-servo added a commit that referenced this pull request May 1, 2019

Auto merge of #23281 - josephhutch:StereoPannerNode, r=Manishearth
StereoPannerNode DOM

<!-- Please describe your changes on the following line: -->

This is the DOM implementation for StereoPannerNode. Backend implemented in servo/media#243.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23281)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@bors-servo bors-servo merged commit 58f0274 into servo:master May 1, 2019

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.