Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex to 1.1 #23289

Merged
merged 1 commit into from Apr 29, 2019
Merged

Update regex to 1.1 #23289

merged 1 commit into from Apr 29, 2019

Conversation

@CYBAI
Copy link
Collaborator

CYBAI commented Apr 29, 2019

I just found the aho-corasick dependency is still 0.6.9 and then I found regex depends on it.

I remember there's a rewrite of aho-corasick at BurntSushi/aho-corasick@e8493ba to improve itself.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it just updates regex crate

This change is Reviewable

@highfive
Copy link

highfive commented Apr 29, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml, components/webdriver_server/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @KiChjang: components/script/Cargo.toml
  • @emilio: components/style/Cargo.toml
@highfive
Copy link

highfive commented Apr 29, 2019

warning Warning warning

  • These commits modify style and script code, but no tests are modified. Please consider adding a test!
@CYBAI
Copy link
Collaborator Author

CYBAI commented Apr 29, 2019

@Eijebong
Copy link
Member

Eijebong commented Apr 29, 2019

@CYBAI I would've just cargo update -p regex and not changed any toml file but nice 👍

@CYBAI
Copy link
Collaborator Author

CYBAI commented Apr 29, 2019

@CYBAI I would've just cargo update -p regex and not changed any toml file but nice 👍

Ahh, thanks! Let me try to run it in case of missing something! 🙇

@CYBAI
Copy link
Collaborator Author

CYBAI commented Apr 29, 2019

Yeah! I tried to run cargo update -p regex and there's no other diff :)

@Eijebong
Copy link
Member

Eijebong commented Apr 29, 2019

Yeah, I was just saying that all the toml changes were useless :)

@jdm
Copy link
Member

jdm commented Apr 29, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2019

📌 Commit 5b9f151 has been approved by jdm

@highfive highfive assigned jdm and unassigned paulrouget Apr 29, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2019

Testing commit 5b9f151 with merge 62031e3...

bors-servo added a commit that referenced this pull request Apr 29, 2019
Update regex to 1.1

I just found the `aho-corasick` dependency is still `0.6.9` and then I found `regex` depends on it.

I remember there's a rewrite of `aho-corasick` at BurntSushi/aho-corasick@e8493ba to improve itself.

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it just updates `regex` crate

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23289)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 29, 2019

@bors-servo bors-servo merged commit 5b9f151 into servo:master Apr 29, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 29, 2019
@CYBAI CYBAI deleted the CYBAI:regex-1.1 branch Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.