Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate regex to 1.1 #23289
Update regex to 1.1 #23289
Conversation
highfive
commented
Apr 29, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 29, 2019
|
cc @Eijebong |
|
@CYBAI I would've just |
Ahh, thanks! Let me try to run it in case of missing something! |
|
Yeah! I tried to run |
|
Yeah, I was just saying that all the toml changes were useless :) |
|
@bors-servo r+ |
|
|
Update regex to 1.1 I just found the `aho-corasick` dependency is still `0.6.9` and then I found `regex` depends on it. I remember there's a rewrite of `aho-corasick` at BurntSushi/aho-corasick@e8493ba to improve itself. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it just updates `regex` crate <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23289) <!-- Reviewable:end -->
|
|
CYBAI commentedApr 29, 2019
•
edited by SimonSapin
I just found the
aho-corasickdependency is still0.6.9and then I foundregexdepends on it.I remember there's a rewrite of
aho-corasickat BurntSushi/aho-corasick@e8493ba to improve itself../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsregexcrateThis change is