Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Leap developer ergonomic improvements #23300

Merged
merged 3 commits into from May 3, 2019
Merged

Conversation

@jdm
Copy link
Member

@jdm jdm commented May 1, 2019

These changes allow passing in command line arguments for Servo via a SERVO_ARGS from the mldb terminal when launching the activity, as well as passing in a launch URL as an argument. It also redirects stdout to the ML log, which allows observing the built-in profiler output.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #23041
  • These changes do not require tests because no magic leap testing.

This change is Reviewable

@highfive
Copy link

@highfive highfive commented May 1, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@jdm
Copy link
Member Author

@jdm jdm commented May 1, 2019

@highfive highfive assigned asajeffrey and unassigned nox May 1, 2019
@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented May 1, 2019

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 1, 2019

📌 Commit 32fd63b has been approved by asajeffrey

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 1, 2019

Testing commit 32fd63b with merge 52712c8...

bors-servo added a commit that referenced this issue May 1, 2019
Magic Leap developer ergonomic improvements

These changes allow passing in command line arguments for Servo via a SERVO_ARGS from the mldb terminal when launching the activity, as well as passing in a launch URL as an argument. It also redirects stdout to the ML log, which allows observing the built-in profiler output.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23041
- [x] These changes do not require tests because no magic leap testing.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23300)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 1, 2019

💔 Test failed - android-mac

@CYBAI
Copy link
Member

@CYBAI CYBAI commented May 2, 2019

Travis complains about tidy

Checking files for tidiness...
./ports/libmlservo/src/lib.rs:72: derivable traits list is not in alphabetical order
	expected: Clone, Copy
	found: Copy, Clone
Running the dependency licensing lint...
 88.0 MiB /  88.0 MiB (100 %)  63.3 MiB/s ETA:   0 s
 88.0 MiB /  88.0 MiB (100 %)   9.4 MiB/s ETA:   0 s
 60.3 MiB /  60.3 MiB (100 %)  12.6 MiB/s ETA:   0 s
  8.9 MiB /  11.1 MiB ( 81 %)   5.1 MiB/s ETA:   0 sinfo: downloading component 'rustfmt'
info: installing component 'rustfmt'
Diff in /home/travis/build/servo/servo/ports/libmlservo/src/lib.rs at line 137:
                 .unwrap_or("")
                 .split(' ')
                 .map(|s| s.to_owned())
-                .collect()
+                .collect(),
         )
     };
     info!("got args: {:?}", args);
Run `./mach fmt` to fix the formatting
The command "./mach test-tidy --no-progress --all" exited with 1.

and android-mac failed with

error[E0433]: failed to resolve: use of undeclared type or module `serde_json`
   --> ports/libsimpleservo/jniapi/src/lib.rs:688:23
    |
688 |         Some(args) => serde_json::from_str(&args)
    |                       ^^^^^^^^^^ use of undeclared type or module `serde_json`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
The following warnings were emitted during compilation:

warning: clang: warning: argument unused during compilation: '-L/Users/servo/buildbot/slave/android-mac/build/android-toolchains/ndk/platforms/android-21/arch-arm/usr/lib' [-Wunused-command-line-argument]

error: Could not compile `simpleservo_jniapi`.

@jdm
Copy link
Member Author

@jdm jdm commented May 2, 2019

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 2, 2019

📌 Commit ff35b36 has been approved by asajeffrey

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 2, 2019

Testing commit ff35b36 with merge 0a871ca...

bors-servo added a commit that referenced this issue May 2, 2019
Magic Leap developer ergonomic improvements

These changes allow passing in command line arguments for Servo via a SERVO_ARGS from the mldb terminal when launching the activity, as well as passing in a launch URL as an argument. It also redirects stdout to the ML log, which allows observing the built-in profiler output.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23041
- [x] These changes do not require tests because no magic leap testing.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23300)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 2, 2019

💔 Test failed - magicleap

@jdm
Copy link
Member Author

@jdm jdm commented May 2, 2019

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 2, 2019

📌 Commit a207574 has been approved by asajeffrey

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 3, 2019

Testing commit a207574 with merge 9e156f2...

bors-servo added a commit that referenced this issue May 3, 2019
Magic Leap developer ergonomic improvements

These changes allow passing in command line arguments for Servo via a SERVO_ARGS from the mldb terminal when launching the activity, as well as passing in a launch URL as an argument. It also redirects stdout to the ML log, which allows observing the built-in profiler output.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23041
- [x] These changes do not require tests because no magic leap testing.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23300)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 3, 2019

💔 Test failed - mac-rel-css1

@jdm
Copy link
Member Author

@jdm jdm commented May 3, 2019

@bors-servo retry

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 3, 2019

Testing commit a207574 with merge 3eb44f3...

bors-servo added a commit that referenced this issue May 3, 2019
Magic Leap developer ergonomic improvements

These changes allow passing in command line arguments for Servo via a SERVO_ARGS from the mldb terminal when launching the activity, as well as passing in a launch URL as an argument. It also redirects stdout to the ML log, which allows observing the built-in profiler output.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23041
- [x] These changes do not require tests because no magic leap testing.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23300)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 3, 2019

💔 Test failed - status-taskcluster

@CYBAI
Copy link
Member

@CYBAI CYBAI commented May 3, 2019

@bors-servo retry

  ▶ FAIL [expected PASS] /html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-display-none-rendering.html
  └   → /html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-display-none-rendering.html f4160efd4d52c3db4cdd078a7efc8d7ca6f60032
/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-display-none-rendering-ref.html 4dfce9506a172505b1a43187270e81ccd23aceda

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 3, 2019

💣 Failed to start rebuilding: Unknown error

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 3, 2019

Testing commit a207574 with merge 60c7266...

bors-servo added a commit that referenced this issue May 3, 2019
Magic Leap developer ergonomic improvements

These changes allow passing in command line arguments for Servo via a SERVO_ARGS from the mldb terminal when launching the activity, as well as passing in a launch URL as an argument. It also redirects stdout to the ML log, which allows observing the built-in profiler output.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23041
- [x] These changes do not require tests because no magic leap testing.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23300)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 3, 2019

@bors-servo bors-servo merged commit a207574 into servo:master May 3, 2019
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants