Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd domain_lookup_start functionality #23310
Conversation
highfive
commented
May 2, 2019
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon. |
highfive
commented
May 2, 2019
|
Heads up! This PR modifies the following files:
|
|
Looks good! Could you squash the commits into one single commit, too? |
|
Ok, commits are sqashed. |
|
@bors-servo try=wpt |
Add domain_lookup_start functionality <!-- Please describe your changes on the following line: --> Added the domain_lookup_start functionality in http_loader.rs (http_redirect_fetch function) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21259 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23310) <!-- Reviewable:end -->
|
|
|
Let's fix the
|
| domain_lookup_end: 0., | ||
| domain_lookup_start: 0., |
This comment has been minimized.
This comment has been minimized.
jdm
May 17, 2019
Member
We need to adjust the from_resource_timing method below this to initialize the value to the stored one as well.
This comment has been minimized.
This comment has been minimized.
|
Sorry about the delay in reviewing this! |
Remove wpt tests for domainLookupStart Set ResourceAttribute::DomainLookupTime Move DomainLookupStart timing before HTTP request initialization Change label of domainLookupStart TAO zero test to PASS Adjust the from_resource_timing method to initialize domain_lookup_start value Restore domainLookupsStart test
|
@jdm squash done |
|
@bors-servo r+ |
|
|
Add domain_lookup_start functionality <!-- Please describe your changes on the following line: --> Added the domain_lookup_start functionality in http_loader.rs (http_redirect_fetch function) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21259 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23310) <!-- Reviewable:end -->
|
|
|
|
@bors-servo r+ |
|
|
Add domain_lookup_start functionality <!-- Please describe your changes on the following line: --> Added the domain_lookup_start functionality in http_loader.rs (http_redirect_fetch function) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21259 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23310) <!-- Reviewable:end -->
|
|
Remove passing test <!-- Please describe your changes on the following line: --> This was added in #23310. Was that a mistake? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23662) <!-- Reviewable:end -->
Remove passing test <!-- Please describe your changes on the following line: --> This was added in #23310. Was that a mistake? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23662) <!-- Reviewable:end -->
KaczuH commentedMay 2, 2019
•
edited by SimonSapin
Added the domain_lookup_start functionality in http_loader.rs (http_redirect_fetch function)
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is