Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1548573 - Upgrade macOS workers to generic-worker 14.1.0 #23319

Merged
merged 4 commits into from May 3, 2019
Merged

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented May 3, 2019

Also follow-up on #23304 to (hopefully) fix use of taskcluster-proxy in daily tasks.


This change is Reviewable

@highfive
Copy link

highfive commented May 3, 2019

Heads up! This PR modifies the following files:

@jdm
jdm approved these changes May 3, 2019
@SimonSapin SimonSapin mentioned this pull request May 3, 2019
9 of 10 tasks complete
@SimonSapin
Copy link
Member Author

SimonSapin commented May 3, 2019

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2019

📌 Commit 75b67a6 has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm May 3, 2019
- runas: {{ user }}

/Library/LaunchAgents/net.generic.worker.plist:
file.managed:
- mode: 644
- mode: 600
- user: root

This comment has been minimized.

@petemoore

petemoore May 3, 2019

Contributor

Is it intended to run tasks as root?

This comment has been minimized.

@SimonSapin

SimonSapin May 3, 2019

Author Member

No. As far as I understand the service runs as the user specified inside of the .plist file, not the one that owns it.

launchctl was complaining and https://stackoverflow.com/questions/28063598/error-while-executing-plist-file-path-had-bad-ownership-permissions suggested this fix.

@jdm
Copy link
Member

jdm commented May 3, 2019

Co-Authored-By: SimonSapin <simon.sapin@exyr.org>
@jdm
Copy link
Member

jdm commented May 3, 2019

@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2019

📌 Commit bc286c9 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2019

Testing commit bc286c9 with merge af077f8...

bors-servo added a commit that referenced this pull request May 3, 2019
Bug 1548573 - Upgrade macOS workers to generic-worker 14.1.0

Also follow-up on #23304 to (hopefully) fix use of `taskcluster-proxy` in daily tasks.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23319)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2019

@bors-servo bors-servo merged commit bc286c9 into master May 3, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the gwup branch May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.