Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create performance resource timing entry for synchronous network fetch #23322

Merged
merged 1 commit into from May 10, 2019
Merged

Create performance resource timing entry for synchronous network fetch #23322

merged 1 commit into from May 10, 2019

Conversation

@pylbrecht
Copy link
Contributor

pylbrecht commented May 4, 2019 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #23150 (GitHub issue number if applicable)
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented May 4, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.
@highfive
Copy link

highfive commented May 4, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/network_listener.rs
  • @KiChjang: components/script/network_listener.rs
@highfive
Copy link

highfive commented May 4, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@pylbrecht
Copy link
Contributor Author

pylbrecht commented May 4, 2019

@jdm, regarding your idea of passing a function pointer to load_whole_resource():
I'm not sure from where to get the required arguments for submit_timing_data() inside load_whole_resource().

Should we just pass more arguments to load_whole_resource()?
I see GlobalScope and ServoUrl floating around in the code calling load_whole_resource(), but what about InitiatorType?
@jdm
jdm requested changes May 6, 2019
View changes
Copy link
Member

jdm left a comment

Yes, passing more arguments to load_whole_resource is a fine choice. As for InitiatorType, the only callers of load_whole_resource fall into the Other category so we might as well hardcode that. I would expect us to remove these callers over time; the synchronous resource loading API isn't great for slow connections.
components/script/network_listener.rs Outdated
}

pub fn submit_timing_data(
global: &DomRoot<GlobalScope>,

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm May 6, 2019

Member

This can be &GlobalScope.
@jdm jdm mentioned this pull request May 6, 2019
Merged
4 of 5 tasks complete
@pylbrecht
Copy link
Contributor Author

pylbrecht commented May 6, 2019 

~jdm | pylbrecht: although we may nave a better solution
~jdm | pylbrecht: all of the callers of load_whole_resource live in script/
~jdm | we could just move load_whole_resource to script and make it call submit_timing_data itself              
~jdm | that's going to be more clear and require rebuilding fewer crates in the future
~jdm | load_whole_resource used to be used by lots of other code, but we're slowly getting rid of it
@jdm
jdm approved these changes May 7, 2019
View changes
@jdm jdm added S-needs-rebase and removed S-awaiting-review labels May 7, 2019
@pylbrecht
Create resource timing entry for sync network fetch
Loading status checks…
e5217ee
@pylbrecht pylbrecht force-pushed the pylbrecht:sync.network.fetch branch from ba8abcb to e5217ee May 8, 2019
@jdm jdm mentioned this pull request May 8, 2019
Merged
3 of 5 tasks complete
@jdm
Copy link
Member

jdm commented May 10, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

📌 Commit e5217ee has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

⌛ Testing commit e5217ee with merge 623c5d0...
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #23322 - pylbrecht:sync.network.fetch, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
623c5d0 
Create performance resource timing entry for synchronous network fetch

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23150 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23322)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request May 10, 2019
Merged
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 623c5d0 to master...
@bors-servo bors-servo mentioned this pull request May 10, 2019
Merged
3 of 5 tasks complete
@bors-servo bors-servo merged commit e5217ee into servo:master May 10, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@pylbrecht pylbrecht deleted the pylbrecht:sync.network.fetch branch May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Synchronous network fetch does not create performance resource timing entry
4 participants
@pylbrecht @highfive @jdm @bors-servo
You can’t perform that action at this time.