Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Ubuntu/Ubuntu 19.04 in bootstrap.py #23324

Merged
merged 3 commits into from May 8, 2019

Conversation

Projects
None yet
5 participants
@marcinwiacek
Copy link
Contributor

commented May 5, 2019

Update handling Ubuntu distributions:

  1. script correctly returns error when some version is/was not supported (checked with Ubuntu 19.04)
  2. for Ubuntu 19.04 Disco Dingo there are correct packages installed

Note: this is my commit to this project, please forgive any mistakes.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because are updating bootstrap.py script

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 5, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

commented May 5, 2019

Heads up! This PR modifies the following files:

@@ -124,7 +124,7 @@ def linux(context, force=False):
'ccache', 'mesa-libGLU-devel', 'clang', 'clang-libs', 'gstreamer1-devel',
'gstreamer1-plugins-base-devel', 'gstreamer1-plugins-bad-free-devel', 'autoconf213']
if context.distro == "Ubuntu":
if context.distro_version == "17.04":
if context.distro_version == "17.04" or context.distro_version == "19.04":

This comment has been minimized.

Copy link
@jdm

jdm May 6, 2019

Member

Let's do if context.distro_version in ["17.04", "19.04"]:

Show resolved Hide resolved python/servo/bootstrap.py

@jdm jdm assigned jdm and unassigned nox May 6, 2019

@jdm

This comment has been minimized.

Copy link
Member

commented May 6, 2019

@bors-servo r+
Thanks!

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

📌 Commit fcbba1d has been approved by jdm

bors-servo added a commit that referenced this pull request May 6, 2019

Auto merge of #23324 - marcinwiacek:ubuntu1904, r=jdm
Changes for Ubuntu/Ubuntu 19.04 in bootstrap.py

Update handling Ubuntu distributions:

1. script correctly returns error when some version is/was not supported (checked with Ubuntu 19.04)
2. for Ubuntu 19.04 Disco Dingo there are correct packages installed

Note: this is my commit to this project, please forgive any mistakes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because are updating bootstrap.py script

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23324)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

⌛️ Testing commit fcbba1d with merge 26686db...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

💔 Test failed - mac-rel-wpt3

@jdm

This comment has been minimized.

Copy link
Member

commented May 6, 2019

@bors-servo retry

@marcinwiacek

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

hmmm, trybot fail seems to be not related. What next?

@marcinwiacek

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

@marcinwiacek: 🔑 Insufficient privileges: not in try users

@jdm

This comment has been minimized.

Copy link
Member

commented May 7, 2019

@bors-servo retry

@jdm

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Oh, we've just had problems with our CI queue for the past 24 hours. It'll get there eventually: https://build.servo.org/homu/queue/servo

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

⌛️ Testing commit fcbba1d with merge 3f1b73a...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

💔 Test failed - mac-rel-wpt3

@jdm

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

⌛️ Testing commit fcbba1d with merge 7f389f3...

bors-servo added a commit that referenced this pull request May 8, 2019

Auto merge of #23324 - marcinwiacek:ubuntu1904, r=jdm
Changes for Ubuntu/Ubuntu 19.04 in bootstrap.py

Update handling Ubuntu distributions:

1. script correctly returns error when some version is/was not supported (checked with Ubuntu 19.04)
2. for Ubuntu 19.04 Disco Dingo there are correct packages installed

Note: this is my commit to this project, please forgive any mistakes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because are updating bootstrap.py script

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23324)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

💔 Test failed - status-taskcluster

@jdm

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

💣 Failed to start rebuilding: Unknown error

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

⌛️ Testing commit fcbba1d with merge 5dbf7cf...

bors-servo added a commit that referenced this pull request May 8, 2019

Auto merge of #23324 - marcinwiacek:ubuntu1904, r=jdm
Changes for Ubuntu/Ubuntu 19.04 in bootstrap.py

Update handling Ubuntu distributions:

1. script correctly returns error when some version is/was not supported (checked with Ubuntu 19.04)
2. for Ubuntu 19.04 Disco Dingo there are correct packages installed

Note: this is my commit to this project, please forgive any mistakes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because are updating bootstrap.py script

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23324)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

💔 Test failed - mac-rel-wpt3

@jdm

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@bors-servo retry

bors-servo added a commit that referenced this pull request May 8, 2019

Auto merge of #23324 - marcinwiacek:ubuntu1904, r=jdm
Changes for Ubuntu/Ubuntu 19.04 in bootstrap.py

Update handling Ubuntu distributions:

1. script correctly returns error when some version is/was not supported (checked with Ubuntu 19.04)
2. for Ubuntu 19.04 Disco Dingo there are correct packages installed

Note: this is my commit to this project, please forgive any mistakes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because are updating bootstrap.py script

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23324)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

⌛️ Testing commit fcbba1d with merge f821fc6...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

@bors-servo bors-servo merged commit fcbba1d into servo:master May 8, 2019

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

@marcinwiacek marcinwiacek deleted the marcinwiacek:ubuntu1904 branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.