Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable video if audio element #23350
Merged
Conversation
highfive
commented
May 9, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
May 9, 2019
|
|
|
@bors-servo r+ |
|
|
|
@bors r- whoops wrong order |
|
@bors-servo r- |
|
LGTM. I filed a follow-up to improve the design a little bit servo/media#258 Thanks! |
|
Needs a rebase |
|
The API to do this was reworked in servo/media: servo/media#266 |
|
Needs a |
|
@jdm Oops! sorry... fixed! |
Otherwise it will only render audio but no video frames.
|
rebased to master @ferjm r? |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 30, 2019
Disable video if audio element And register frame renderer only if video element Requires the merge of servo/media#257 <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23336 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23350) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ceyusa commentedMay 9, 2019
•
edited by SimonSapin
And register frame renderer only if video element
Requires the merge of servo/media#257
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is