Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libffi to pkgconfig's search path. #23359

Merged
merged 1 commit into from May 10, 2019
Merged

Add libffi to pkgconfig's search path. #23359

merged 1 commit into from May 10, 2019

Conversation

@jdm
Copy link
Member

jdm commented May 10, 2019 •
edited by SimonSapin

Fixes #23358.

This change is Reviewable
@jdm
Copy link
Member Author

jdm commented May 10, 2019

@bors-servo p=100 r+
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

📌 Commit 20957c6 has been approved by jdm
@highfive highfive assigned jdm and unassigned ferjm May 10, 2019
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #23359 - jdm:fix-ffi-tc, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
871bcc0 
Add libffi to pkgconfig's search path.

Fixes #23358.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23359)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

⌛ Testing commit 20957c6 with merge 871bcc0...
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented May 10, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

⌛ Testing commit 20957c6 with merge a2c85c9...
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #23359 - jdm:fix-ffi-tc, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a2c85c9 
Add libffi to pkgconfig's search path.

Fixes #23358.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23359)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented May 10, 2019

@bors-servo treeclosed=99
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented May 10, 2019

I'm looking into the openssl failure.
@jdm
Add libffi to pkgconfig's search path.
Loading status checks…
e050e4f
@jdm jdm force-pushed the jdm:fix-ffi-tc branch from 20957c6 to e050e4f May 10, 2019
@jdm
Copy link
Member Author

jdm commented May 10, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

📌 Commit e050e4f has been approved by jdm
@jdm
Copy link
Member Author

jdm commented May 10, 2019

@bors-servo try=mac
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

⌛ Trying commit 4d6a4ce with merge cac8b0c...
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #23359 - jdm:fix-ffi-tc, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cac8b0c 
Add libffi to pkgconfig's search path.

Fixes #23358.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23359)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented May 10, 2019

Amazing. System integrity protection is enabled on servo-tc-mac3, so DYLD_LIBRARY_PATH has no effect. It's disabled on the other TC mac build machines, so I'm going to take this machine out of the pool until I can get macstadium to look at it.
@jdm
Copy link
Member Author

jdm commented May 10, 2019

@bors-servo treeclosed-
@CYBAI CYBAI mentioned this pull request May 10, 2019
Merged
3 of 5 tasks complete
@jdm jdm force-pushed the jdm:fix-ffi-tc branch from 4d6a4ce to e050e4f May 10, 2019
@jdm
Copy link
Member Author

jdm commented May 10, 2019

r? @SimonSapin
@highfive highfive assigned SimonSapin and unassigned jdm May 10, 2019
@SimonSapin
Copy link
Member

SimonSapin commented May 10, 2019

I’m not super familiar with pkg-config details, but if CI is happy I’m happy.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

📌 Commit e050e4f has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

⌛ Testing commit e050e4f with merge 542bdf6...
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #23359 - jdm:fix-ffi-tc, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
542bdf6 
Add libffi to pkgconfig's search path.

Fixes #23358.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23359)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented May 10, 2019

@bors-servo retry
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #23359 - jdm:fix-ffi-tc, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b13f7ab 
Add libffi to pkgconfig's search path.

Fixes #23358.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23359)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

⌛ Testing commit e050e4f with merge b13f7ab...
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: SimonSapin
Pushing b13f7ab to master...
@bors-servo bors-servo merged commit e050e4f into servo:master May 10, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

servo-tc-mac3 doesn't pass the gstreamer check
6 participants
@jdm @bors-servo @CYBAI @SimonSapin @ferjm @highfive
You can’t perform that action at this time.