Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use llvm toolchain for android build #23364

Merged
merged 1 commit into from May 25, 2019
Merged

Use llvm toolchain for android build #23364

merged 1 commit into from May 25, 2019
+17 −22

Conversation

@jdm
Copy link
Member

jdm commented May 10, 2019 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented May 10, 2019

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented May 10, 2019

@bors-servo try=android
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

⌛ Trying commit 7277e17 with merge 1534160...
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #23364 - jdm:ndk-llvm2, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1534160 
Use llvm toolchain for android build

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23364)
<!-- Reviewable:end -->
@jdm jdm unassigned nox May 10, 2019
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2019

☀️ Test successful - android-mac, status-taskcluster
State: approved= try=True
@jdm
Copy link
Member Author

jdm commented May 10, 2019

r? @asajeffrey
@jdm
Copy link
Member Author

jdm commented May 15, 2019

@asajeffrey Review ping!
@asajeffrey
Copy link
Member

asajeffrey commented May 23, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2019

📌 Commit 7277e17 has been approved by asajeffrey
@jdm
Copy link
Member Author

jdm commented May 23, 2019

@bors-servo r-
Need to resolve the merge conflict first.
@jdm
Use llvm toolchain for entirety of android build.
Loading status checks…
ccde586
@jdm jdm force-pushed the jdm:ndk-llvm2 branch from 7277e17 to ccde586 May 24, 2019
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2019

📌 Commit ccde586 has been approved by asajeffrey
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo r-
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2019

📌 Commit ccde586 has been approved by asajeffrey
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo r-
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo r=asajeffrey clean
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2019

📌 Commit ccde586 has been approved by asajeffrey
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo r-
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2019

📌 Commit ccde586 has been approved by asajeffrey
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo retry
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo force r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2019

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #23448
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2019

📌 Commit ccde586 has been approved by asajeffrey
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo r-
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo r=asajeffrey force
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2019

📌 Commit ccde586 has been approved by asajeffrey
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo r-
@jdm
Copy link
Member Author

jdm commented May 24, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2019

📌 Commit ccde586 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2019

⌛ Testing commit ccde586 with merge 61d2641...
bors-servo added a commit that referenced this pull request May 24, 2019
@bors-servo
Auto merge of #23364 - jdm:ndk-llvm2, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
61d2641 
Use llvm toolchain for android build

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23364)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: asajeffrey
Pushing 61d2641 to master...
@bors-servo bors-servo merged commit ccde586 into servo:master May 25, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @bors-servo @asajeffrey @nox
You can’t perform that action at this time.