Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable webrtc by default, enable webrtc wpt tests #23377

Closed
wants to merge 13 commits into from

Conversation

@Manishearth
Copy link
Member

@Manishearth Manishearth commented May 13, 2019

This change is Reviewable

@servo-wpt-sync
Copy link
Collaborator

@servo-wpt-sync servo-wpt-sync commented May 13, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1557782177925.

Loading

@servo-wpt-sync
Copy link
Collaborator

@servo-wpt-sync servo-wpt-sync commented May 13, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1557782180740.

Loading

@highfive
Copy link

@highfive highfive commented May 13, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/MediaStreamTrack.webidl, components/script/dom/webidls/MediaDevices.webidl, components/script/dom/webidls/MediaStream.webidl
  • @jgraham: tests/wpt/include.ini
  • @KiChjang: components/script/dom/webidls/MediaStreamTrack.webidl, components/script/dom/webidls/MediaDevices.webidl, components/script/dom/webidls/MediaStream.webidl

Loading

@servo-wpt-sync
Copy link
Collaborator

@servo-wpt-sync servo-wpt-sync commented May 13, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1557782183709.

Loading

@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 13, 2019

Loading

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 13, 2019

Trying commit 7566c87 with merge 139f071...

Loading

bors-servo added a commit that referenced this issue May 13, 2019
Enable webrtc by default, enable webrtc wpt tests

None
@@ -129,6 +129,8 @@ skip: true
skip: false
[webvr]
skip: false
[webvr]
Copy link
Member

@jdm jdm May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong directory.

Loading

@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 13, 2019

Loading

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 13, 2019

Trying commit b32e48d with merge a1bc33e...

Loading

bors-servo added a commit that referenced this issue May 13, 2019
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 13, 2019

Loading

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 13, 2019

Trying commit 4bc81e6 with merge 22a6bb2...

Loading

bors-servo added a commit that referenced this issue May 13, 2019
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 13, 2019

Alright, looks like we're missing a webrtcbin element. I guess this needs to be explicitly enabled?

Loading

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 13, 2019

💔 Test failed - linux-rel-css

Loading

@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 14, 2019

Loading

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 14, 2019

Trying commit b3dc63b with merge 67186d4...

Loading

bors-servo added a commit that referenced this issue May 14, 2019
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 14, 2019

💔 Test failed - linux-rel-css

Loading

@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 14, 2019

Oh, right, mach boostrap just fixes it for users.

servo/saltfs#960

Loading

@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 14, 2019

The mediacapture tests will fail because we have no media devices :|

Not sure what we can do here, perhaps I should just remove that commit.

Loading

@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 16, 2019

That file is on the server, I checked :/

Loading

@Manishearth Manishearth mentioned this pull request May 16, 2019
bors-servo added a commit that referenced this issue May 16, 2019
Update servo-media

Ensuring the gl failures in #23377 are not caused by this

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23416)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 16, 2019

@bors-servo try=wpt

Loading

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 16, 2019

Trying commit 00c9cc2 with merge b6744bc...

Loading

bors-servo added a commit that referenced this issue May 16, 2019
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 16, 2019

💔 Test failed - linux-rel-css

Loading

@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 17, 2019

@bors-servo try=wpt

Loading

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 17, 2019

Trying commit cc36d4d with merge 57c8b79...

Loading

bors-servo added a commit that referenced this issue May 17, 2019
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 17, 2019

💔 Test failed - linux-rel-css

Loading

@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 17, 2019

@bors-servo try=wpt

Loading

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 17, 2019

Trying commit 02ce6b0 with merge 740f577...

Loading

bors-servo added a commit that referenced this issue May 17, 2019
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented May 17, 2019

This should pass, but It's unclear to me why there's a discrepancy between this and what runs locally

Loading

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 17, 2019

💔 Test failed - linux-rel-css

Loading

bors-servo added a commit that referenced this issue May 18, 2019
Update servo-media

Ensuring the gl failures in #23377 are not caused by this

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23416)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 19, 2019
Update servo-media

Ensuring the gl failures in #23377 are not caused by this

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23416)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented Jun 10, 2019

Closing for now.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants