Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable webrtc by default, enable webrtc wpt tests #23377

Closed
wants to merge 13 commits into from
Closed

Enable webrtc by default, enable webrtc wpt tests #23377

wants to merge 13 commits into from

Conversation

@Manishearth
Copy link
Member

Manishearth commented May 13, 2019 •
edited by SimonSapin

This change is Reviewable
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 13, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1557782177925.
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 13, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1557782180740.
@highfive
Copy link

highfive commented May 13, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/MediaStreamTrack.webidl, components/script/dom/webidls/MediaDevices.webidl, components/script/dom/webidls/MediaStream.webidl
  • @jgraham: tests/wpt/include.ini
  • @KiChjang: components/script/dom/webidls/MediaStreamTrack.webidl, components/script/dom/webidls/MediaDevices.webidl, components/script/dom/webidls/MediaStream.webidl
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented May 13, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1557782183709.
@Manishearth
Copy link
Member Author

Manishearth commented May 13, 2019

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2019

⌛ Trying commit 7566c87 with merge 139f071...
bors-servo added a commit that referenced this pull request May 13, 2019
@bors-servo
Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
139f071 
Enable webrtc by default, enable webrtc wpt tests

None
@jdm
jdm reviewed May 13, 2019
View changes
tests/wpt/include.ini
@@ -129,6 +129,8 @@ skip: true
skip: false
[webvr]
skip: false
[webvr]

This comment has been minimized.

Sign in to view
@jdm

jdm May 13, 2019

Member

Wrong directory.
@Manishearth Manishearth force-pushed the Manishearth:webrtc-wpt branch from 7566c87 to b32e48d May 13, 2019
@Manishearth
Copy link
Member Author

Manishearth commented May 13, 2019

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2019

⌛ Trying commit b32e48d with merge a1bc33e...
bors-servo added a commit that referenced this pull request May 13, 2019
@bors-servo
Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a1bc33e 
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

Manishearth commented May 13, 2019

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2019

⌛ Trying commit 4bc81e6 with merge 22a6bb2...
bors-servo added a commit that referenced this pull request May 13, 2019
@bors-servo
Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
22a6bb2 
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

Manishearth commented May 13, 2019

Alright, looks like we're missing a webrtcbin element. I guess this needs to be explicitly enabled?
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2019

💔 Test failed - linux-rel-css
@Manishearth
Copy link
Member Author

Manishearth commented May 14, 2019

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2019

⌛ Trying commit b3dc63b with merge 67186d4...
bors-servo added a commit that referenced this pull request May 14, 2019
@bors-servo
Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
67186d4 
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2019

💔 Test failed - linux-rel-css
@Manishearth
Copy link
Member Author

Manishearth commented May 14, 2019

Oh, right, mach boostrap just fixes it for users.

servo/saltfs#960
@Manishearth
Copy link
Member Author

Manishearth commented May 14, 2019

The mediacapture tests will fail because we have no media devices :|

Not sure what we can do here, perhaps I should just remove that commit.
@Manishearth Manishearth force-pushed the Manishearth:webrtc-wpt branch from b3dc63b to 3f7f3c5 May 14, 2019
@Manishearth
Copy link
Member Author

Manishearth commented May 16, 2019

That file is on the server, I checked :/
@Manishearth Manishearth mentioned this pull request May 16, 2019
Merged
bors-servo added a commit that referenced this pull request May 16, 2019
@bors-servo
Auto merge of #23416 - Manishearth:mediaup, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
75d6ef0 
Update servo-media

Ensuring the gl failures in #23377 are not caused by this

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23416)
<!-- Reviewable:end -->
@Manishearth
Update metadata
Loading status checks…
00c9cc2
@Manishearth Manishearth force-pushed the Manishearth:webrtc-wpt branch from fae2bfa to 00c9cc2 May 16, 2019
@Manishearth
Copy link
Member Author

Manishearth commented May 16, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2019

⌛ Trying commit 00c9cc2 with merge b6744bc...
bors-servo added a commit that referenced this pull request May 16, 2019
@bors-servo
Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b6744bc 
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2019

💔 Test failed - linux-rel-css
@Manishearth
Copy link
Member Author

Manishearth commented May 17, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2019

⌛ Trying commit cc36d4d with merge 57c8b79...
bors-servo added a commit that referenced this pull request May 17, 2019
@bors-servo
Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
57c8b79 
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2019

💔 Test failed - linux-rel-css
@Manishearth
another update?
Loading status checks…
02ce6b0
@Manishearth Manishearth force-pushed the Manishearth:webrtc-wpt branch from cc36d4d to 02ce6b0 May 17, 2019
@Manishearth
Copy link
Member Author

Manishearth commented May 17, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2019

⌛ Trying commit 02ce6b0 with merge 740f577...
bors-servo added a commit that referenced this pull request May 17, 2019
@bors-servo
Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
740f577 
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

Manishearth commented May 17, 2019

This should pass, but It's unclear to me why there's a discrepancy between this and what runs locally
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2019

💔 Test failed - linux-rel-css
bors-servo added a commit that referenced this pull request May 18, 2019
@bors-servo
Auto merge of #23416 - Manishearth:mediaup, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7457666 
Update servo-media

Ensuring the gl failures in #23377 are not caused by this

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23416)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request May 19, 2019
@bors-servo
Auto merge of #23416 - Manishearth:mediaup, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9b6a35c 
Update servo-media

Ensuring the gl failures in #23377 are not caused by this

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23416)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member Author

Manishearth commented Jun 10, 2019

Closing for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@avadacatavra avadacatavra

Labels
S-awaiting-review S-needs-rebase S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@Manishearth @servo-wpt-sync @highfive @bors-servo @jdm @Darkspirit @ferjm @avadacatavra
You can’t perform that action at this time.