Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable webrtc by default, enable webrtc wpt tests #23377

Closed
wants to merge 13 commits into from

Conversation

Projects
None yet
8 participants
@Manishearth
Copy link
Member

commented May 13, 2019

This change is Reviewable

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1557782177925.

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1557782180740.

@highfive

This comment has been minimized.

Copy link

commented May 13, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/MediaStreamTrack.webidl, components/script/dom/webidls/MediaDevices.webidl, components/script/dom/webidls/MediaStream.webidl
  • @jgraham: tests/wpt/include.ini
  • @KiChjang: components/script/dom/webidls/MediaStreamTrack.webidl, components/script/dom/webidls/MediaDevices.webidl, components/script/dom/webidls/MediaStream.webidl
@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1557782183709.

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

⌛️ Trying commit 7566c87 with merge 139f071...

bors-servo added a commit that referenced this pull request May 13, 2019

Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Enable webrtc by default, enable webrtc wpt tests

None
@@ -129,6 +129,8 @@ skip: true
skip: false
[webvr]
skip: false
[webvr]

This comment has been minimized.

Copy link
@jdm

jdm May 13, 2019

Member

Wrong directory.

@Manishearth Manishearth force-pushed the Manishearth:webrtc-wpt branch from 7566c87 to b32e48d May 13, 2019

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

⌛️ Trying commit b32e48d with merge a1bc33e...

bors-servo added a commit that referenced this pull request May 13, 2019

Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

⌛️ Trying commit 4bc81e6 with merge 22a6bb2...

bors-servo added a commit that referenced this pull request May 13, 2019

Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

Alright, looks like we're missing a webrtcbin element. I guess this needs to be explicitly enabled?

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

💔 Test failed - linux-rel-css

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

⌛️ Trying commit b3dc63b with merge 67186d4...

bors-servo added a commit that referenced this pull request May 14, 2019

Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

💔 Test failed - linux-rel-css

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

Oh, right, mach boostrap just fixes it for users.

servo/saltfs#960

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

The mediacapture tests will fail because we have no media devices :|

Not sure what we can do here, perhaps I should just remove that commit.

@Manishearth Manishearth force-pushed the Manishearth:webrtc-wpt branch from b3dc63b to 3f7f3c5 May 14, 2019

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

That file is on the server, I checked :/

@Manishearth Manishearth referenced this pull request May 16, 2019

Merged

Update servo-media #23416

bors-servo added a commit that referenced this pull request May 16, 2019

Auto merge of #23416 - Manishearth:mediaup, r=<try>
Update servo-media

Ensuring the gl failures in #23377 are not caused by this

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23416)
<!-- Reviewable:end -->

@Manishearth Manishearth force-pushed the Manishearth:webrtc-wpt branch from fae2bfa to 00c9cc2 May 16, 2019

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

⌛️ Trying commit 00c9cc2 with merge b6744bc...

bors-servo added a commit that referenced this pull request May 16, 2019

Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

💔 Test failed - linux-rel-css

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

⌛️ Trying commit cc36d4d with merge 57c8b79...

bors-servo added a commit that referenced this pull request May 17, 2019

Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

💔 Test failed - linux-rel-css

@Manishearth Manishearth force-pushed the Manishearth:webrtc-wpt branch from cc36d4d to 02ce6b0 May 17, 2019

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

⌛️ Trying commit 02ce6b0 with merge 740f577...

bors-servo added a commit that referenced this pull request May 17, 2019

Auto merge of #23377 - Manishearth:webrtc-wpt, r=<try>
Enable webrtc by default, enable webrtc wpt tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23377)
<!-- Reviewable:end -->
@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

This should pass, but It's unclear to me why there's a discrepancy between this and what runs locally

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

💔 Test failed - linux-rel-css

bors-servo added a commit that referenced this pull request May 18, 2019

Auto merge of #23416 - Manishearth:mediaup, r=asajeffrey
Update servo-media

Ensuring the gl failures in #23377 are not caused by this

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23416)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request May 19, 2019

Auto merge of #23416 - Manishearth:mediaup, r=asajeffrey
Update servo-media

Ensuring the gl failures in #23377 are not caused by this

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23416)
<!-- Reviewable:end -->
@Manishearth

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.