Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBuild Linux Nightly with OpenSSL 1.1.0 #23392
Merged
Conversation
|
r? @jdm |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 15, 2019
Build Linux Nightly with OpenSSL 1.1.0 Servo Nightly fails to run on Ubuntu 19.04 (disco) as it doesn't have a libssl1.0.0 package. OpenSSL 1.1.x is supported since [Debian Stretch](https://packages.debian.org/en/stretch/libssl1.1) (currently Debian Stable) and [Ubuntu 18.04](https://packages.ubuntu.com/bionic/libssl1.1) (used by base.dockerfile). Ancient Debian + Ubuntu releases are still able to compile Servo using their most recent OpenSSL (1.0.x). --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12015, fix #21778 and fix #22110 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23392) <!-- Reviewable:end -->
Merged
|
@bors-servo p=1001 treeclosed=1000 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Darkspirit commentedMay 15, 2019
•
edited
Servo Nightly fails to run on Ubuntu 19.04 (disco) as it doesn't have a libssl1.0.0 package.
OpenSSL 1.1.x is supported since Debian Stretch (currently Debian Stable) and Ubuntu 18.04 (used by base.dockerfile).
Ancient Debian + Ubuntu releases are still able to compile Servo using their most recent OpenSSL (1.0.x).
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is