Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some SSH keys to tc-mac workers #23412

Merged
merged 1 commit into from May 24, 2019
Merged

Add some SSH keys to tc-mac workers #23412

merged 1 commit into from May 24, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented May 16, 2019 •
edited

This change is Reviewable
@Manishearth
Copy link
Member

Manishearth commented May 16, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2019

📌 Commit 71ee3ce has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2019

⌛ Testing commit 71ee3ce with merge fb622fb...
bors-servo added a commit that referenced this pull request May 18, 2019
@bors-servo
Auto merge of #23412 - servo:ssh, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fb622fb 
Add some SSH keys to tc-mac workers

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23412)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2019

💥 Test timed out
@CYBAI
Copy link
Collaborator

CYBAI commented May 18, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2019

⌛ Testing commit 71ee3ce with merge fe0d6b8...
bors-servo added a commit that referenced this pull request May 18, 2019
@bors-servo
Auto merge of #23412 - servo:ssh, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fe0d6b8 
Add some SSH keys to tc-mac workers

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23412)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented May 19, 2019

Travis and TC complained about tidy 👀

Checking files for tidiness...
./etc/taskcluster/macos/modules/pillar/ssh_keys.py:7: E302 expected 2 blank lines, found 1
@SimonSapin
Add some SSH keys to tc-mac workers
Loading status checks…
ed4c1ff
@SimonSapin
Copy link
Member Author

SimonSapin commented May 23, 2019

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2019

📌 Commit ed4c1ff has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2019

⌛ Testing commit ed4c1ff with merge 9869ed7...
bors-servo added a commit that referenced this pull request May 23, 2019
@bors-servo
Auto merge of #23412 - servo:ssh, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9869ed7 
Add some SSH keys to tc-mac workers

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23412)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 23, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented May 23, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2019

⌛ Testing commit ed4c1ff with merge 5ffa689...
bors-servo added a commit that referenced this pull request May 24, 2019
@bors-servo
Auto merge of #23412 - servo:ssh, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5ffa689 
Add some SSH keys to tc-mac workers

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23412)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing 5ffa689 to master...
@bors-servo bors-servo merged commit ed4c1ff into master May 24, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the ssh branch Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @Manishearth @bors-servo @CYBAI @jdm @highfive
You can’t perform that action at this time.