Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start enabling automated webdriver tests #23443

Merged
merged 3 commits into from Jun 7, 2019

Conversation

Projects
None yet
6 participants
@georgeroman
Copy link
Contributor

commented May 22, 2019


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 22, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/lib.rs
  • @jgraham: components/webdriver_server/lib.rs, tests/wpt/include.ini
@jdm

This comment has been minimized.

Copy link
Member

commented May 22, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

⌛️ Trying commit a80566d with merge d01c6dd...

bors-servo added a commit that referenced this pull request May 22, 2019

Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=<try>
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

💔 Test failed - linux-rel-wpt

@jdm

jdm approved these changes Jun 3, 2019

@jdm jdm removed the S-awaiting-review label Jun 3, 2019

@jdm jdm assigned jdm and unassigned SimonSapin Jun 3, 2019

@jdm

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

@bors-servo delegate+
This can merge after the next successful WPT sync, which will include web-platform-tests/wpt#17047.

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

✌️ @georgeroman can now approve this pull request

@georgeroman georgeroman force-pushed the georgeroman:start_enabling_wdspec_tests branch from a80566d to e3a3cf2 Jun 4, 2019

@jdm

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

@bors-servo try=wpt

bors-servo added a commit that referenced this pull request Jun 5, 2019

Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=<try>
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

⌛️ Trying commit e3a3cf2 with merge aa739e3...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

STDERR: [2019-06-05 18:36:26,926] [INFO] mod_pywebsocket.standalone.WebSocketServer: Create socket on: (2, 1, 6, '', ('127.0.0.1', 8889))
STDERR: [2019-06-05 18:36:26,926] [INFO] mod_pywebsocket.standalone.WebSocketServer: Create socket on: (2, 1, 6, '', ('127.0.0.1', 8888))
STDERR: [2019-06-05 18:36:26,927] [INFO] mod_pywebsocket.standalone.WebSocketServer: Bind on: (2, 1, 6, '', ('127.0.0.1', 8888))
STDERR: [2019-06-05 18:36:26,927] [INFO] mod_pywebsocket.standalone.WebSocketServer: Listen on: (2, 1, 6, '', ('127.0.0.1', 8888))
STDERR: [2019-06-05 18:36:26,928] [INFO] mod_pywebsocket.standalone.WebSocketServer: Bind on: (2, 1, 6, '', ('127.0.0.1', 8889))
STDERR: [2019-06-05 18:36:26,928] [INFO] mod_pywebsocket.standalone.WebSocketServer: Listen on: (2, 1, 6, '', ('127.0.0.1', 8889))
STDERR: [2019-06-05 18:36:26,934] [DEBUG] mod_pywebsocket.standalone.WebSocketServer: SSLEOFError(8, u'EOF occurred in violation of protocol (_ssl.c:590)')
Running 4 tests in web-platform-tests

STDERR: [2019-06-05 18:36:26,945] [DEBUG] mod_pywebsocket.standalone.WebSocketServer: SSLEOFError(8, u'EOF occurred in violation of protocol (_ssl.c:590)')
Max restarts exceeded
Unsupported test type wdspec for product servodriver
Max restarts exceeded
Max restarts exceeded

Ran 0 tests finished in 6.0 seconds.
  • 0 ran as expected. 0 tests skipped.

That's not a good sign!

@georgeroman georgeroman force-pushed the georgeroman:start_enabling_wdspec_tests branch from e3a3cf2 to 60c2c1d Jun 6, 2019

@highfive highfive removed the S-tests-failed label Jun 6, 2019

@georgeroman

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

@bors-servo try=wpt

@georgeroman

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

I opened an issue for this: web-platform-tests/wpt#17210.

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

⌛️ Testing commit 60c2c1d with merge f051128...

bors-servo added a commit that referenced this pull request Jun 6, 2019

Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=jdm
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

💔 Test failed - status-taskcluster

@jdm

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

bors-servo added a commit that referenced this pull request Jun 6, 2019

Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=jdm
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

⌛️ Testing commit 60c2c1d with merge d126fe4...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

💔 Test failed - status-taskcluster

@jdm

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

⌛️ Testing commit 60c2c1d with merge 0faec40...

bors-servo added a commit that referenced this pull request Jun 7, 2019

Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=jdm
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

💔 Test failed - status-taskcluster

@CYBAI

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

⌛️ Testing commit 60c2c1d with merge 237ef8d...

bors-servo added a commit that referenced this pull request Jun 7, 2019

Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=jdm
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 237ef8d to master...

@bors-servo bors-servo merged commit 60c2c1d into servo:master Jun 7, 2019

3 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.