Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start enabling automated webdriver tests #23443

Merged
merged 3 commits into from Jun 7, 2019
Merged

Start enabling automated webdriver tests #23443

merged 3 commits into from Jun 7, 2019
+256 −26

Conversation

@georgeroman
Copy link
Contributor

georgeroman commented May 22, 2019 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented May 22, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/lib.rs
  • @jgraham: components/webdriver_server/lib.rs, tests/wpt/include.ini
@jdm
Copy link
Member

jdm commented May 22, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2019

⌛ Trying commit a80566d with merge d01c6dd...
bors-servo added a commit that referenced this pull request May 22, 2019
@bors-servo
Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d01c6dd 
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2019

💔 Test failed - linux-rel-wpt
@georgeroman georgeroman mentioned this pull request May 28, 2019
Merged
@jdm
jdm approved these changes Jun 3, 2019
View changes
@jdm jdm removed the S-awaiting-review label Jun 3, 2019
@jdm jdm assigned jdm and unassigned SimonSapin Jun 3, 2019
@jdm
Copy link
Member

jdm commented Jun 3, 2019

@bors-servo delegate+
This can merge after the next successful WPT sync, which will include web-platform-tests/wpt#17047.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2019

✌️ @georgeroman can now approve this pull request
@jdm
Copy link
Member

jdm commented Jun 5, 2019

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Jun 5, 2019
@bors-servo
Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aa739e3 
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2019

⌛ Trying commit e3a3cf2 with merge aa739e3...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2019

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Jun 5, 2019 

STDERR: [2019-06-05 18:36:26,926] [INFO] mod_pywebsocket.standalone.WebSocketServer: Create socket on: (2, 1, 6, '', ('127.0.0.1', 8889))
STDERR: [2019-06-05 18:36:26,926] [INFO] mod_pywebsocket.standalone.WebSocketServer: Create socket on: (2, 1, 6, '', ('127.0.0.1', 8888))
STDERR: [2019-06-05 18:36:26,927] [INFO] mod_pywebsocket.standalone.WebSocketServer: Bind on: (2, 1, 6, '', ('127.0.0.1', 8888))
STDERR: [2019-06-05 18:36:26,927] [INFO] mod_pywebsocket.standalone.WebSocketServer: Listen on: (2, 1, 6, '', ('127.0.0.1', 8888))
STDERR: [2019-06-05 18:36:26,928] [INFO] mod_pywebsocket.standalone.WebSocketServer: Bind on: (2, 1, 6, '', ('127.0.0.1', 8889))
STDERR: [2019-06-05 18:36:26,928] [INFO] mod_pywebsocket.standalone.WebSocketServer: Listen on: (2, 1, 6, '', ('127.0.0.1', 8889))
STDERR: [2019-06-05 18:36:26,934] [DEBUG] mod_pywebsocket.standalone.WebSocketServer: SSLEOFError(8, u'EOF occurred in violation of protocol (_ssl.c:590)')
Running 4 tests in web-platform-tests

STDERR: [2019-06-05 18:36:26,945] [DEBUG] mod_pywebsocket.standalone.WebSocketServer: SSLEOFError(8, u'EOF occurred in violation of protocol (_ssl.c:590)')
Max restarts exceeded
Unsupported test type wdspec for product servodriver
Max restarts exceeded
Max restarts exceeded

Ran 0 tests finished in 6.0 seconds.
  • 0 ran as expected. 0 tests skipped.

That's not a good sign!
georgeroman added 3 commits May 23, 2019
@georgeroman
Do not exit servo on webdriver session deletion
5ce09a5
@georgeroman
Enable webdriver new_session tests
8b93d1d
@georgeroman
Add ServoCapabilities and revise handle_new_session function
Loading status checks…
60c2c1d
@highfive highfive removed the S-tests-failed label Jun 6, 2019
@georgeroman
Copy link
Contributor Author

georgeroman commented Jun 6, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Jun 6, 2019

⌛ Trying commit 60c2c1d with merge d71f7b5...
bors-servo added a commit that referenced this pull request Jun 6, 2019
@bors-servo
Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d71f7b5 
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@georgeroman
Copy link
Contributor Author

georgeroman commented Jun 6, 2019

I opened an issue for this: web-platform-tests/wpt#17210.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 6, 2019

⌛ Testing commit 60c2c1d with merge f051128...
bors-servo added a commit that referenced this pull request Jun 6, 2019
@bors-servo
Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f051128 
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 6, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jun 6, 2019 •
edited

@bors-servo retry
bors-servo added a commit that referenced this pull request Jun 6, 2019
@bors-servo
Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d126fe4 
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 6, 2019

⌛ Testing commit 60c2c1d with merge d126fe4...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jun 7, 2019

@bors-servo retry
#23290
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

⌛ Testing commit 60c2c1d with merge 0faec40...
bors-servo added a commit that referenced this pull request Jun 7, 2019
@bors-servo
Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0faec40 
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Jun 7, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

⌛ Testing commit 60c2c1d with merge 237ef8d...
bors-servo added a commit that referenced this pull request Jun 7, 2019
@bors-servo
Auto merge of #23443 - georgeroman:start_enabling_wdspec_tests, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
237ef8d 
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 237ef8d to master...
@bors-servo bors-servo merged commit 60c2c1d into servo:master Jun 7, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@georgeroman @highfive @jdm @bors-servo @CYBAI @SimonSapin
You can’t perform that action at this time.