Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start enabling automated webdriver tests #23443

Merged
merged 3 commits into from Jun 7, 2019
Merged

Start enabling automated webdriver tests #23443

merged 3 commits into from Jun 7, 2019

Conversation

@georgeroman
Copy link
Contributor

@georgeroman georgeroman commented May 22, 2019


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable

@highfive
Copy link

@highfive highfive commented May 22, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/lib.rs
  • @jgraham: components/webdriver_server/lib.rs, tests/wpt/include.ini

@jdm
Copy link
Member

@jdm jdm commented May 22, 2019

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 22, 2019

Trying commit a80566d with merge d01c6dd...

bors-servo added a commit that referenced this issue May 22, 2019
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 22, 2019

💔 Test failed - linux-rel-wpt

jdm
jdm approved these changes Jun 3, 2019
@jdm jdm assigned jdm and unassigned SimonSapin Jun 3, 2019
@jdm
Copy link
Member

@jdm jdm commented Jun 3, 2019

@bors-servo delegate+
This can merge after the next successful WPT sync, which will include web-platform-tests/wpt#17047.

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 3, 2019

✌️ @georgeroman can now approve this pull request

@jdm
Copy link
Member

@jdm jdm commented Jun 5, 2019

@bors-servo try=wpt

bors-servo added a commit that referenced this issue Jun 5, 2019
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 5, 2019

Trying commit e3a3cf2 with merge aa739e3...

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 5, 2019

💔 Test failed - linux-rel-wpt

@jdm
Copy link
Member

@jdm jdm commented Jun 5, 2019

STDERR: [2019-06-05 18:36:26,926] [INFO] mod_pywebsocket.standalone.WebSocketServer: Create socket on: (2, 1, 6, '', ('127.0.0.1', 8889))
STDERR: [2019-06-05 18:36:26,926] [INFO] mod_pywebsocket.standalone.WebSocketServer: Create socket on: (2, 1, 6, '', ('127.0.0.1', 8888))
STDERR: [2019-06-05 18:36:26,927] [INFO] mod_pywebsocket.standalone.WebSocketServer: Bind on: (2, 1, 6, '', ('127.0.0.1', 8888))
STDERR: [2019-06-05 18:36:26,927] [INFO] mod_pywebsocket.standalone.WebSocketServer: Listen on: (2, 1, 6, '', ('127.0.0.1', 8888))
STDERR: [2019-06-05 18:36:26,928] [INFO] mod_pywebsocket.standalone.WebSocketServer: Bind on: (2, 1, 6, '', ('127.0.0.1', 8889))
STDERR: [2019-06-05 18:36:26,928] [INFO] mod_pywebsocket.standalone.WebSocketServer: Listen on: (2, 1, 6, '', ('127.0.0.1', 8889))
STDERR: [2019-06-05 18:36:26,934] [DEBUG] mod_pywebsocket.standalone.WebSocketServer: SSLEOFError(8, u'EOF occurred in violation of protocol (_ssl.c:590)')
Running 4 tests in web-platform-tests

STDERR: [2019-06-05 18:36:26,945] [DEBUG] mod_pywebsocket.standalone.WebSocketServer: SSLEOFError(8, u'EOF occurred in violation of protocol (_ssl.c:590)')
Max restarts exceeded
Unsupported test type wdspec for product servodriver
Max restarts exceeded
Max restarts exceeded

Ran 0 tests finished in 6.0 seconds.
  • 0 ran as expected. 0 tests skipped.

That's not a good sign!

@georgeroman
Copy link
Contributor Author

@georgeroman georgeroman commented Jun 6, 2019

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 6, 2019

Trying commit 60c2c1d with merge d71f7b5...

bors-servo added a commit that referenced this issue Jun 6, 2019
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@georgeroman
Copy link
Contributor Author

@georgeroman georgeroman commented Jun 6, 2019

I opened an issue for this: web-platform-tests/wpt#17210.

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 6, 2019

Testing commit 60c2c1d with merge f051128...

bors-servo added a commit that referenced this issue Jun 6, 2019
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 6, 2019

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

@jdm jdm commented Jun 6, 2019

bors-servo added a commit that referenced this issue Jun 6, 2019
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 6, 2019

Testing commit 60c2c1d with merge d126fe4...

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 7, 2019

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

@jdm jdm commented Jun 7, 2019

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 7, 2019

Testing commit 60c2c1d with merge 0faec40...

bors-servo added a commit that referenced this issue Jun 7, 2019
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 7, 2019

💔 Test failed - status-taskcluster

@CYBAI
Copy link
Member

@CYBAI CYBAI commented Jun 7, 2019

@bors-servo retry

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 7, 2019

Testing commit 60c2c1d with merge 237ef8d...

bors-servo added a commit that referenced this issue Jun 7, 2019
Start enabling automated webdriver tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23443)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented Jun 7, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 237ef8d to master...

@bors-servo bors-servo merged commit 60c2c1d into servo:master Jun 7, 2019
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants