Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an inCompartments config option for bindings #23459

Merged
merged 4 commits into from Jun 2, 2019

Conversation

Projects
None yet
6 participants
@Eijebong
Copy link
Member

commented May 25, 2019

Fixes #23257


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 25, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/testbinding.rs, components/script/fetch.rs, components/script/dom/workerglobalscope.rs, components/script/dom/bindings/codegen/Bindings.conf and 3 more
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/testbinding.rs, components/script/fetch.rs, components/script/dom/workerglobalscope.rs, components/script/dom/bindings/codegen/Bindings.conf and 3 more
@highfive

This comment has been minimized.

Copy link

commented May 25, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@Eijebong

This comment has been minimized.

Copy link
Member Author

commented May 25, 2019

r? @jdm

@highfive highfive assigned jdm and unassigned nox May 25, 2019

@Eijebong Eijebong force-pushed the Eijebong:compartments branch from bb6acd5 to 292d468 May 25, 2019

@emilio

This comment has been minimized.

Copy link
Member

commented May 25, 2019

Don't have much saying on this, but I think this would be nicer as a [NeedsCompartment] extended attribute or something like that.

@jdm

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

Sorry for sitting on this! I am happy to merge these changes as-is; we can decide to switch to an extended attribute later.

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

📌 Commit b7e10a8 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

⌛️ Testing commit b7e10a8 with merge 03f2236...

bors-servo added a commit that referenced this pull request Jun 2, 2019

Auto merge of #23459 - Eijebong:compartments, r=jdm
Add an inCompartments config option for bindings

Fixes #23257

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23459)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 03f2236 to master...

@bors-servo bors-servo merged commit b7e10a8 into servo:master Jun 2, 2019

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@bors-servo bors-servo referenced this pull request Jun 2, 2019

Open

Enter dom compartment wrapper #23344

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.