Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow simultaneous playback of audio and video for getUserMedia #23476

Merged
merged 1 commit into from May 30, 2019
Merged

Allow simultaneous playback of audio and video for getUserMedia #23476

merged 1 commit into from May 30, 2019
+19 −18

Conversation

@ferjm
Copy link
Member

ferjm commented May 29, 2019 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable
@ferjm
Allow simultaneous playback of audio and video for getUserMedia
Loading status checks…
dfbf7e3
@highfive
Copy link

highfive commented May 29, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlmediaelement.rs
  • @KiChjang: components/script/dom/htmlmediaelement.rs
@highfive
Copy link

highfive commented May 29, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@ferjm
Copy link
Member Author

ferjm commented May 29, 2019

r? @ceyusa
@highfive highfive assigned ceyusa and unassigned Manishearth May 29, 2019
@ceyusa
Copy link
Collaborator

ceyusa commented May 29, 2019

You just won me the PR!!!
Just let me add above it a commit for the only audio.
@ceyusa ceyusa mentioned this pull request May 29, 2019
Merged
3 of 5 tasks complete
@ceyusa
Copy link
Collaborator

ceyusa commented May 29, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2019

@ceyusa: 🔑 Insufficient privileges: Not in reviewers
@ceyusa
Copy link
Collaborator

ceyusa commented May 29, 2019

@ceyusa: key Insufficient privileges: Not in reviewers

Ok :(

but r+ fmpov
@Manishearth
Copy link
Member

Manishearth commented May 29, 2019

@bors-servo r=ceyusa
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2019

📌 Commit dfbf7e3 has been approved by ceyusa
@ceyusa
Copy link
Collaborator

ceyusa commented May 29, 2019

Build execution time has reached the maximum allowed time for your plan (100 minutes).

??
@jdm
Copy link
Member

jdm commented May 29, 2019

It happens sometimes.
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2019

⌛ Testing commit dfbf7e3 with merge 5f1f235...
bors-servo added a commit that referenced this pull request May 29, 2019
@bors-servo
Auto merge of #23476 - ferjm:multi.streams, r=ceyusa
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5f1f235 
Allow simultaneous playback of audio and video for getUserMedia

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23476)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented May 29, 2019

@bors-servo retry
bors-servo added a commit that referenced this pull request May 29, 2019
@bors-servo
Auto merge of #23476 - ferjm:multi.streams, r=ceyusa
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e2a24e6 
Allow simultaneous playback of audio and video for getUserMedia

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23476)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2019

⌛ Testing commit dfbf7e3 with merge e2a24e6...
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented May 30, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2019

⌛ Testing commit dfbf7e3 with merge 0a9a222...
bors-servo added a commit that referenced this pull request May 30, 2019
@bors-servo
Auto merge of #23476 - ferjm:multi.streams, r=ceyusa
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0a9a222 
Allow simultaneous playback of audio and video for getUserMedia

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23476)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: ceyusa
Pushing 0a9a222 to master...
@bors-servo bors-servo merged commit dfbf7e3 into servo:master May 30, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@ferjm ferjm deleted the ferjm:multi.streams branch May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ceyusa ceyusa

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@ferjm @highfive @ceyusa @bors-servo @Manishearth @jdm
You can’t perform that action at this time.