Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gstreamer on Windows to 1.16.0. #23484

Merged
merged 3 commits into from Jun 4, 2019
Merged

Update gstreamer on Windows to 1.16.0. #23484

merged 3 commits into from Jun 4, 2019

Conversation

@jdm
Copy link
Member

jdm commented May 30, 2019 •
edited

Fixes #23348.

This change is Reviewable
@jdm
Update gstreamer on Windows to 1.16.0.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8ae2873
@jdm jdm unassigned nox May 30, 2019
@jdm
Copy link
Member Author

jdm commented May 30, 2019

I'm hoping this will fix #23348.
@jdm
Copy link
Member Author

jdm commented May 30, 2019

@bors-servo try=windows
bors-servo added a commit that referenced this pull request May 30, 2019
@bors-servo
Auto merge of #23484 - servo:jdm-patch-53, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5106f90 
Update gstreamer on Windows to 1.16.0.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23484)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2019

⌛ Trying commit 0f5afe8 with merge 5106f90...
@jdm jdm mentioned this pull request May 30, 2019
Closed
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented May 30, 2019

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2019

⌛ Trying commit 4163410 with merge ac6bf6b...
bors-servo added a commit that referenced this pull request May 30, 2019
@bors-servo
Auto merge of #23484 - servo:jdm-patch-53, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ac6bf6b 
Update gstreamer on Windows to 1.16.0.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23484)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented May 30, 2019

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2019

⌛ Trying commit aa6ae6b with merge 7b49038...
bors-servo added a commit that referenced this pull request May 30, 2019
@bors-servo
Auto merge of #23484 - servo:jdm-patch-53, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7b49038 
Update gstreamer on Windows to 1.16.0.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23484)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented May 31, 2019

The build ran on my Windows machine. Let's get this merged!
@jdm
Copy link
Member Author

jdm commented May 31, 2019

r? @ferjm
@jdm jdm force-pushed the jdm-patch-53 branch 3 times, most recently from 33460ac to 130ef10 May 31, 2019
@ferjm
ferjm approved these changes May 31, 2019
View changes
Copy link
Member

ferjm left a comment

r=me as soon as AppVeyor finishes
@jdm
Copy link
Member Author

jdm commented May 31, 2019

@bors-servo r=ferjm
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2019

📌 Commit 130ef10 has been approved by ferjm
@jdm
Package DLLs correctly for Windows cross builds.
96c51cf
@jdm jdm force-pushed the jdm-patch-53 branch from 1d71041 to 654ea53 Jun 3, 2019
@jdm
Copy link
Member Author

jdm commented Jun 3, 2019

Yep, I broke the DLL copying. I've added a couple assertions to avoid that happening again.
@jdm
Copy link
Member Author

jdm commented Jun 3, 2019

@bors-servo try=windows
bors-servo added a commit that referenced this pull request Jun 3, 2019
@bors-servo
Auto merge of #23484 - servo:jdm-patch-53, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
23b2745 
Update gstreamer on Windows to 1.16.0.

Fixes #23348.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23484)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2019

⌛ Trying commit 654ea53 with merge 23b2745...
@jdm
Update gstreamer on appveyor.
Loading status checks…
c973587
@jdm jdm force-pushed the jdm-patch-53 branch from 654ea53 to c973587 Jun 3, 2019
@jdm
Copy link
Member Author

jdm commented Jun 3, 2019

@bors-servo r=Manishearth
@highfive highfive assigned Manishearth and unassigned ferjm Jun 3, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2019

📌 Commit c973587 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2019

⌛ Testing commit c973587 with merge 6caef7e...
bors-servo added a commit that referenced this pull request Jun 3, 2019
@bors-servo
Auto merge of #23484 - servo:jdm-patch-53, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6caef7e 
Update gstreamer on Windows to 1.16.0.

Fixes #23348.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23484)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Jun 3, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2019

⌛ Testing commit c973587 with merge 3a2705f...
bors-servo added a commit that referenced this pull request Jun 3, 2019
@bors-servo
Auto merge of #23484 - servo:jdm-patch-53, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3a2705f 
Update gstreamer on Windows to 1.16.0.

Fixes #23348.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23484)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing 3a2705f to master...
@bors-servo bors-servo merged commit c973587 into master Jun 4, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@Manishearth Manishearth mentioned this pull request Jun 6, 2019
Closed
5 of 6 tasks complete
@SimonSapin SimonSapin deleted the jdm-patch-53 branch Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferjm ferjm

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

libiconv-2.dll is missing from Windows nightly
6 participants
@jdm @bors-servo @ferjm @nox @Manishearth @highfive
You can’t perform that action at this time.