Basic XR Testing support #23485

Manishearth · 2019-05-30T22:21:53Z

This adds support for the XRTest and FakeXRDeviceController APIs from https://github.com/immersive-web/webxr-test-api, and plugs them into the mock backend of rust-webvr.

Tested with a modified webxr test page

r? @jdm @asajeffrey

This change is


        Add blank XRTest interface


        Add blank FakeXRDeviceController interface


        Update rust-webvr


        Add XR.test()

highfive · 2019-05-30T22:21:59Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/XRTest.webidl, components/script/dom/xrtest.rs, components/script/dom/fakexrdevicecontroller.rs, components/script/dom/xrspace.rs, components/script/dom/mod.rs and 3 more
@wafflespeanut: python/tidy/servo_tidy/tidy.py
@edunham: python/tidy/servo_tidy/tidy.py
@paulrouget: components/servo/lib.rs
@KiChjang: components/script/dom/webidls/XRTest.webidl, components/script/dom/xrtest.rs, components/script/dom/fakexrdevicecontroller.rs, components/script/dom/xrspace.rs, components/script/dom/mod.rs and 3 more

highfive · 2019-05-30T22:22:01Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

asajeffrey

LGTM with minor nits.

asajeffrey · 2019-05-31T01:32:57Z

components/config/prefs.rs

@@ -294,6 +294,8 @@ mod gen {
                webxr: {
                    #[serde(default)]
                    enabled: bool,
+                    #[serde(default)]
+                    test: bool,


A bit annoying that this does something different than dom.webvr.test which renders to a GLWindow. At some point we'll have to come up with consistent naming.

I'm also okay with this rendering to a GLWindow in the future, but I'd have to teach the mock backend about it

asajeffrey · 2019-05-31T01:32:57Z

components/script/dom/fakexrdevicecontroller.rs

+}
+
+impl FakeXRDeviceControllerMethods for FakeXRDeviceController {
+    // check-tidy: no specs after this line


No spec links :(

there's no spec! there's https://github.com/immersive-web/webxr-test-api , but it's not really a spec. I've linked to it in a bunch of places

Manishearth · 2019-05-31T01:55:37Z

@bors-servo r=asajeffrey

bors-servo · 2019-05-31T01:55:38Z

📌 Commit 001eb53 has been approved by asajeffrey

bors-servo · 2019-05-31T01:55:44Z

⌛ Testing commit 001eb53 with merge 2f3aacd...


        Auto merge of #23485 - Manishearth:xrtest, r=asajeffrey

@jdm

Basic XR Testing support This adds support for the XRTest and FakeXRDeviceController APIs from https://github.com/immersive-web/webxr-test-api, and plugs them into the `mock` backend of rust-webvr. Tested with [a modified webxr test page](https://github.com/immersive-web/webxr-test-api) r? @jdm @asajeffrey  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23485)

bors-servo · 2019-05-31T02:01:19Z

💔 Test failed - linux-rel-css


        Support creating and messaging mock display


        Add XRTest.simulateDeviceConnection()


        Add FakeXRDeviceController.setViews()


        Add FakeXRDeviceController.setViewerOrigin()


        Run webvr thread when webxr is enabled


        Normalize rotations


        Add 'spec' links

Manishearth · 2019-05-31T02:04:18Z

@bors-servo r=asajeffrey

bors-servo · 2019-05-31T02:04:18Z

📌 Commit c2d4900 has been approved by asajeffrey

bors-servo · 2019-05-31T02:04:23Z

⌛ Testing commit c2d4900 with merge 7c8a4ec...


        Auto merge of #23485 - Manishearth:xrtest, r=asajeffrey

@jdm

Basic XR Testing support This adds support for the XRTest and FakeXRDeviceController APIs from https://github.com/immersive-web/webxr-test-api, and plugs them into the `mock` backend of rust-webvr. Tested with [a modified webxr test page](https://github.com/immersive-web/webxr-test-api) r? @jdm @asajeffrey  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23485)

bors-servo · 2019-05-31T04:46:34Z

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: asajeffrey
Pushing 7c8a4ec to master...

Manishearth added 4 commits May 29, 2019

Add blank XRTest interface

1c07b0f

Add blank FakeXRDeviceController interface

9a31f6f

Update rust-webvr

422fadd

Add XR.test()

c689866

highfive assigned jdm May 30, 2019

highfive added the S-awaiting-review label May 30, 2019

asajeffrey approved these changes May 31, 2019

View changes

Manishearth force-pushed the Manishearth:xrtest branch from c741d98 to ed4fbd0 May 31, 2019

highfive assigned asajeffrey and unassigned jdm May 31, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels May 31, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels May 31, 2019

Manishearth added 7 commits May 29, 2019

Support creating and messaging mock display

a89d2c6

Add XRTest.simulateDeviceConnection()

e95b24b

Add FakeXRDeviceController.setViews()

4b930b9

Add FakeXRDeviceController.setViewerOrigin()

97df39f

Run webvr thread when webxr is enabled

366aa78

Normalize rotations

d044a79

Add 'spec' links

Loading status checks…

c2d4900

Manishearth force-pushed the Manishearth:xrtest branch from 001eb53 to c2d4900 May 31, 2019

highfive removed the S-tests-failed label May 31, 2019

highfive added S-awaiting-review S-awaiting-merge and removed S-awaiting-review labels May 31, 2019

highfive removed the S-awaiting-merge label May 31, 2019

bors-servo mentioned this pull request May 31, 2019

Media player rendering with GL textures #23483

Merged

2 of 2 tasks complete

servo / servo

Basic XR Testing support #23485

Basic XR Testing support #23485

Manishearth commented May 30, 2019 •

edited by SimonSapin

highfive commented May 30, 2019

highfive commented May 30, 2019

asajeffrey left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Manishearth commented May 31, 2019

bors-servo commented May 31, 2019

bors-servo commented May 31, 2019

bors-servo commented May 31, 2019

Manishearth commented May 31, 2019

bors-servo commented May 31, 2019

bors-servo commented May 31, 2019

bors-servo commented May 31, 2019

servo / servo

Join GitHub today

Basic XR Testing support #23485

Basic XR Testing support #23485

Conversation

Manishearth commented May 30, 2019 • edited by SimonSapin

highfive commented May 30, 2019

highfive commented May 30, 2019

asajeffrey left a comment

This comment has been minimized.

asajeffrey May 31, 2019

This comment has been minimized.

Manishearth May 31, 2019

This comment has been minimized.

asajeffrey May 31, 2019

This comment has been minimized.

Manishearth May 31, 2019

Manishearth commented May 31, 2019

bors-servo commented May 31, 2019

bors-servo commented May 31, 2019

bors-servo commented May 31, 2019

Manishearth commented May 31, 2019

bors-servo commented May 31, 2019

bors-servo commented May 31, 2019

bors-servo commented May 31, 2019

Manishearth commented May 30, 2019 •

edited by SimonSapin