Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcompositing: removed opts-get #23493
Merged
Conversation
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jun 1, 2019
compositing: removed opts-get <!-- Please describe your changes on the following line: --> Removed all `opts::get()` from `compositing` component. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes *partially* fix #22854 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they are not feature- or bug-related changes. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23493) <!-- Reviewable:end -->
|
@jdm Let me know if you'd prefer a PR per component, or a single PR with the entire issue fixed (thus, with the changes from all listed components). |
|
r? @jdm |
|
|
|
Since we have removed the only use of servo_config from this crate, we can now remove the dependency from components/compositing/Cargo.toml. Thanks! |
|
@bors-servo r+ |
|
|
|
@jdm thanks for the help with the 1st contribution! proceeding with the rest now. |
bors-servo
added a commit
that referenced
this pull request
Jun 3, 2019
compositing: removed opts-get <!-- Please describe your changes on the following line: --> Removed all `opts::get()` from `compositing` component. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix *partially* #22854 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they are not feature- or bug-related changes. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23493) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
oneturkmen commentedJun 1, 2019
•
edited by atouchet
Removed all
opts::get()fromcompositingcomponent../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is