Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code (3/N) #23499

Merged
merged 2 commits into from Jun 4, 2019
Merged

Remove unused code (3/N) #23499

merged 2 commits into from Jun 4, 2019
+4 −203

Conversation

@est31
Copy link
Contributor

est31 commented Jun 2, 2019 •
edited by SimonSapin

Third PR in a series of PRs to remove unused/dead code from servo, powered by an (upcoming) tool of mine. Please take a look and tell me if you want to keep something.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because they only remove dead code

This change is Reviewable
@est31
Remove unused code from script* crates
8b6ed3d
@highfive
Copy link

highfive commented Jun 2, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/attr.rs, components/script/dom/bindings/mod.rs, components/script/dom/document.rs, components/script/dom/element.rs, components/script/dom/bindings/root.rs and 6 more
  • @KiChjang: components/script/dom/attr.rs, components/script/dom/bindings/mod.rs, components/script/dom/document.rs, components/script/dom/element.rs, components/script/dom/bindings/root.rs and 7 more
  • @emilio: components/style/properties/cascade.rs
@highfive
Copy link

highfive commented Jun 2, 2019

warning Warning warning

  • These commits modify style and script code, but no tests are modified. Please consider adding a test!
@jdm
jdm requested changes Jun 2, 2019
View changes
components/script/compartments.rs Outdated Show resolved Hide resolved
components/selectors/context.rs Outdated Show resolved Hide resolved
@est31
Remove unused code from a bunch of crates
Loading status checks…
e64de8d
@est31 est31 force-pushed the est31:unused_code_removal_3 branch from 2d9deae to e64de8d Jun 3, 2019
@est31
Copy link
Contributor Author

est31 commented Jun 3, 2019 •
edited

I've re-added the code in a way that doesn't touch the git blame. r? @jdm
@highfive highfive assigned jdm and unassigned asajeffrey Jun 3, 2019
@jdm
Copy link
Member

jdm commented Jun 3, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2019

📌 Commit e64de8d has been approved by jdm
bors-servo added a commit that referenced this pull request Jun 4, 2019
@bors-servo
Auto merge of #23499 - est31:unused_code_removal_3, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
330b744 
Remove unused code (3/N)

<!-- Please describe your changes on the following line: -->

Third PR in a series of PRs to remove unused/dead code from servo, powered by an (upcoming) tool of mine. Please take a look and tell me if you want to keep something.

* First PR: #23477
* Second PR: #23498

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they only remove dead code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23499)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2019

⌛ Testing commit e64de8d with merge 330b744...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Jun 4, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2019

⌛ Testing commit e64de8d with merge faf3a18...
bors-servo added a commit that referenced this pull request Jun 4, 2019
@bors-servo
Auto merge of #23499 - est31:unused_code_removal_3, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
faf3a18 
Remove unused code (3/N)

<!-- Please describe your changes on the following line: -->

Third PR in a series of PRs to remove unused/dead code from servo, powered by an (upcoming) tool of mine. Please take a look and tell me if you want to keep something.

* First PR: #23477
* Second PR: #23498

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they only remove dead code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23499)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 4, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing faf3a18 to master...
@bors-servo bors-servo merged commit e64de8d into servo:master Jun 4, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@est31 est31 mentioned this pull request Jun 7, 2019
Merged
3 of 4 tasks complete
bors-servo added a commit that referenced this pull request Jun 7, 2019
@bors-servo
Auto merge of #23532 - est31:unused_code_removal_4, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ffa2be4 
Remove unused code (4/4)

<!-- Please describe your changes on the following line: -->

Fourth and final PR in a series of PRs to remove unused/dead code from servo, powered by an (upcoming) tool of mine. Please take a look and tell me if you want to keep something.

* First PR: #23477
* Second PR: #23498
* Third PR: #23499

Shortstat of the combined PR series:
```
47 files changed, 7 insertions(+), 805 deletions(-)
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they only remove dead code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23532)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Jun 8, 2019
@bors-servo
Auto merge of #23532 - est31:unused_code_removal_4, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0d5c6a0 
Remove unused code (4/4)

<!-- Please describe your changes on the following line: -->

Fourth and final PR in a series of PRs to remove unused/dead code from servo, powered by an (upcoming) tool of mine. Please take a look and tell me if you want to keep something.

* First PR: #23477
* Second PR: #23498
* Third PR: #23499

Shortstat of the combined PR series:
```
47 files changed, 7 insertions(+), 805 deletions(-)
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they only remove dead code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23532)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

@emilio emilio

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@est31 @highfive @jdm @bors-servo @CYBAI @emilio @asajeffrey
You can’t perform that action at this time.