Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StaticStructGenerator on Windows #23502

Closed
wants to merge 2 commits into from
Closed

Use StaticStructGenerator on Windows #23502

wants to merge 2 commits into from

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Jun 3, 2019 •
edited by SimonSapin

This change is Reviewable
@paulrouget
Use StaticStructGenerator on Windows
Loading status checks…
67c3433
@paulrouget
Copy link
Contributor Author

paulrouget commented Jun 3, 2019

Not ready for review, just want to see if the CI is happy with this change (probably gonna break because of EGL missing).
@jdm
Copy link
Member

jdm commented Jun 3, 2019

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2019

⌛ Trying commit 67c3433 with merge 64fa23f...
bors-servo added a commit that referenced this pull request Jun 3, 2019
@bors-servo
Auto merge of #23502 - paulrouget:winegl, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
64fa23f 
Use StaticStructGenerator on Windows

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23502)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Jun 3, 2019

Windows CI was green: https://treeherder.allizom.org/#/jobs?repo=servo-try&revision=64fa23fde90bd81507326c8b3124f676cdfc3315
@jdm
Copy link
Member

jdm commented Jun 3, 2019

Nevermind; none of our Windows CI builds libsimpleservo.
@jdm
Build libsimpleservo on Windows.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8640bd7
@jdm
Copy link
Member

jdm commented Jun 3, 2019

@bors-servo try=windows
bors-servo added a commit that referenced this pull request Jun 3, 2019
@bors-servo
Auto merge of #23502 - paulrouget:winegl, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f2d0429 
Use StaticStructGenerator on Windows

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23502)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2019

⌛ Trying commit 8640bd7 with merge f2d0429...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 3, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jun 3, 2019 

  = note: lld-link.exe: error: could not open libegl.lib: no such file or directory

As expected.
@paulrouget
Copy link
Contributor Author

paulrouget commented Jun 6, 2019

@jdm libsimpleservo will require egl.dll.

We could re-use the one provided by MS angle. Builds are available here https://www.nuget.org/packages/ANGLE.WindowsStore/ zip file is https://www.nuget.org/api/v2/package/ANGLE.WindowsStore/{version} (2.1.13 atm).

Not sure if we want to install it system-wise on the CI and let users provide their own EGL library (like we do for gstreamer) or, make it so that mach download that specific version of EGL.

Any recommendation?
@jdm
Copy link
Member

jdm commented Jun 6, 2019

I am inclined to have mach download it.
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 3, 2019

Closing in favor of #23696
@paulrouget paulrouget closed this Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
P-hololens S-awaiting-review S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@paulrouget @jdm @bors-servo @SimonSapin @highfive
You can’t perform that action at this time.