Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upConstellation: removed almost all opts::get #23506
Merged
Conversation
highfive
commented
Jun 4, 2019
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon. |
highfive
commented
Jun 4, 2019
|
Heads up! This PR modifies the following files:
|
|
r? @jdm |
|
Looks good! We should be able to remove remaining Opts usage from this code after we finish converting the remaining crates, since it's only used to call |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 4, 2019
Constellation: removed almost all opts::get <!-- Please describe your changes on the following line: --> Removed *almost* all (except 1) "opts::get()" from `constellation` component. The one untouched is in `pipeline.rs` which uses "opts::get()" as a [struct field](https://github.com/oneturkmen/servo/blob/cd153efb4acce81170927790653555c5f10929eb/components/constellation/pipeline.rs#L501) that is set [here](https://github.com/oneturkmen/servo/blob/cd153efb4acce81170927790653555c5f10929eb/components/constellation/pipeline.rs#L296). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix *partially* #22854 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because no feature (or no bug) has been added (refactoring only). <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23506) <!-- Reviewable:end -->
|
|
|
@jdm it seems that it failed when downloading cmake - |
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Jun 4, 2019
Constellation: removed almost all opts::get <!-- Please describe your changes on the following line: --> Removed *almost* all (except 1) "opts::get()" from `constellation` component. The one untouched is in `pipeline.rs` which uses "opts::get()" as a [struct field](https://github.com/oneturkmen/servo/blob/cd153efb4acce81170927790653555c5f10929eb/components/constellation/pipeline.rs#L501) that is set [here](https://github.com/oneturkmen/servo/blob/cd153efb4acce81170927790653555c5f10929eb/components/constellation/pipeline.rs#L296). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix *partially* #22854 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because no feature (or no bug) has been added (refactoring only). <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23506) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
oneturkmen commentedJun 4, 2019
•
edited by SimonSapin
Removed almost all (except 1) "opts::get()" from
constellationcomponent. The one untouched is inpipeline.rswhich uses "opts::get()" as a struct field that is set here../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is