Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplink DOMImplementation to owner Document rather than Window #2351
Conversation
highfive
commented
May 6, 2014
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon. |
hoppipolla-critic-bot
commented
May 6, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1483 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
I'm sorry, but our decision stands. |
|
The decision was made by people who do not understand what they are even discussing, and therefore the discussion is of no use. Show me a license agreement, I will sign it, and all of these misguided fears will vanish. The fears ought not to be there in the first place, but from a legal standpoint they will have no more reason to exist |
caitp commentedMay 6, 2014
This matches implementations in Blink and WebKit, and passes an extra 14 web-platform-tests.
I've re-opened this because I disagree with the decision to close the other one over a fear of withdrawing consent for the code to be used.
Show me a CLA, I'll sign it and hand over rights to whatever N lines of code there are here. I am not the kind of person to back out of a legally binding agreement.
Closes #2230