Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link DOMImplementation to owner Document rather than Window #2351

Closed
wants to merge 1 commit into from

Conversation

@caitp
Copy link

caitp commented May 6, 2014

This matches implementations in Blink and WebKit, and passes an extra 14 web-platform-tests.

I've re-opened this because I disagree with the decision to close the other one over a fear of withdrawing consent for the code to be used.

Show me a CLA, I'll sign it and hand over rights to whatever N lines of code there are here. I am not the kind of person to back out of a legally binding agreement.

Closes #2230

This matches implementations in Blink and WebKit, and passes an extra 14 web-platform-tests.

Closes #2230
@highfive
Copy link

highfive commented May 6, 2014

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 6, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1483

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@metajack
Copy link
Contributor

metajack commented May 6, 2014

I'm sorry, but our decision stands.

@metajack metajack closed this May 6, 2014
@caitp
Copy link
Author

caitp commented May 6, 2014

The decision was made by people who do not understand what they are even discussing, and therefore the discussion is of no use.

Show me a license agreement, I will sign it, and all of these misguided fears will vanish. The fears ought not to be there in the first place, but from a legal standpoint they will have no more reason to exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.