Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade WebRender #23516
Upgrade WebRender #23516
Conversation
highfive
commented
Jun 5, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jun 5, 2019
|
@pcwalton The RNG crate problems can usually be resolved by upgrading the crates in question. |
|
OK, this one should work. |
|
@bors-servo try=wpt |
Upgrade WebRender This is against an old Servo because I can't build current Servo due to compile errors in RNG crates. I verified that it starts up. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23516) <!-- Reviewable:end -->
|
|
|
|
|
@bors-servo try=wpt |
Upgrade WebRender This is against an old Servo because I can't build current Servo due to compile errors in RNG crates. I verified that it starts up. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23516) <!-- Reviewable:end -->
|
This should have addressed all of the previous test failures. Thank you for doing all of the preliminary work, @pcwalton! |
|
|
Also this needs to be rebased after the diverse rand update thingy (it should dedupe ws and sha1 too) |
|
@bors-servo try=wpt |
Upgrade WebRender This is against an old Servo because I can't build current Servo due to compile errors in RNG crates. I verified that it starts up. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23516 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23516) <!-- Reviewable:end -->
|
|
|
This one pass again in the second Mac build
besides, in error[E0432]: unresolved import `servo::webrender_api::DevicePixel`
--> ports/libmlservo/src/lib.rs:17:5
|
17 | use servo::webrender_api::DevicePixel;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `DevicePixel` in `webrender_api`
error[E0432]: unresolved import `servo::webrender_api::DevicePoint`
--> ports/libmlservo/src/lib.rs:18:5
|
18 | use servo::webrender_api::DevicePoint;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `DevicePoint` in `webrender_api`
error[E0432]: unresolved import `servo::webrender_api::LayoutPixel`
--> ports/libmlservo/src/lib.rs:19:5
|
19 | use servo::webrender_api::LayoutPixel;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `LayoutPixel` in `webrender_api`
error: aborting due to 3 previous errors |
|
@bors-servo r=pcwalton,jdm |
|
|
Upgrade WebRender This is against an old Servo because I can't build current Servo due to compile errors in RNG crates. I verified that it starts up. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23516 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23516) <!-- Reviewable:end -->
|
|
pcwalton commentedJun 5, 2019
•
edited by jdm
This is against an old Servo because I can't build current Servo due to compile errors in RNG crates. I verified that it starts up.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is