Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: removed opts::get() #23521

Merged
merged 1 commit into from Jun 7, 2019
Merged

Profile: removed opts::get() #23521

merged 1 commit into from Jun 7, 2019
+37 −20

Conversation

@oneturkmen
Copy link
Contributor

oneturkmen commented Jun 6, 2019 •
edited by SimonSapin

Removed opts::get() from profile component. Note that profile_traits component is the only component that uses single opts::get().signpost for IpcBytesReceiver and IpcReceiver structs, i.e. for recv() type method.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix partially #22854 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because these are cleanup changes.

This change is Reviewable
@highfive
Copy link

highfive commented Jun 6, 2019

Heads up! This PR modifies the following files:
@oneturkmen
Copy link
Contributor Author

oneturkmen commented Jun 6, 2019

r? @jdm
@highfive highfive assigned jdm and unassigned Manishearth Jun 6, 2019
@jdm
Copy link
Member

jdm commented Jun 6, 2019

Some unit tests in tests/unit/profile/time.rs need to be updated as well. This can be tested with ./mach test-unit -p profile.
@oneturkmen
Profile: removed opts::get()
Loading status checks…
f29ae9d
@oneturkmen oneturkmen force-pushed the oneturkmen:profile-remove-opts-get branch from 6c7945e to f29ae9d Jun 6, 2019
@oneturkmen
Copy link
Contributor Author

oneturkmen commented Jun 7, 2019

@jdm I fixed the unit tests, but appveyor fails to build. I guess it has to do something with cygwin's persistent shared memory. Do you think build restart/retry will help?
@oneturkmen
Copy link
Contributor Author

oneturkmen commented Jun 7, 2019

PS. I did not touch the single opts::get() in components/profile_traits because it's used by recv(), which is in turn used throughout the codebase (not all, but it's reused in many places). I don't think we should touch it unless it's very necessary to do so (otherwise, there would probably be breaking changes).
@jdm
Copy link
Member

jdm commented Jun 7, 2019

Agreed, that will require some thought.
@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

📌 Commit f29ae9d has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

⌛ Testing commit f29ae9d with merge b8cb8b2...
bors-servo added a commit that referenced this pull request Jun 7, 2019
@bors-servo
Auto merge of #23521 - oneturkmen:profile-remove-opts-get, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b8cb8b2 
Profile: removed opts::get()

<!-- Please describe your changes on the following line: -->
Removed opts::get() from `profile` component. **Note** that `profile_traits` component is the only component that uses single `opts::get().signpost` for IpcBytesReceiver and IpcReceiver structs, i.e. for recv() type method.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix *partially* #22854 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because these are cleanup changes.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23521)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jun 7, 2019

@bors-servo retry
#23290
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

⌛ Testing commit f29ae9d with merge a634f05...
bors-servo added a commit that referenced this pull request Jun 7, 2019
@bors-servo
Auto merge of #23521 - oneturkmen:profile-remove-opts-get, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a634f05 
Profile: removed opts::get()

<!-- Please describe your changes on the following line: -->
Removed opts::get() from `profile` component. **Note** that `profile_traits` component is the only component that uses single `opts::get().signpost` for IpcBytesReceiver and IpcReceiver structs, i.e. for recv() type method.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix *partially* #22854 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because these are cleanup changes.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23521)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing a634f05 to master...
@bors-servo bors-servo merged commit f29ae9d into servo:master Jun 7, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@oneturkmen oneturkmen deleted the oneturkmen:profile-remove-opts-get branch Jun 7, 2019
@oneturkmen oneturkmen mentioned this pull request Jul 2, 2019
Open
6 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@oneturkmen @highfive @jdm @bors-servo @Manishearth
You can’t perform that action at this time.