Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code (4/4) #23532

Merged
merged 1 commit into from Jun 8, 2019
Merged

Remove unused code (4/4) #23532

merged 1 commit into from Jun 8, 2019

Conversation

@est31
Copy link
Contributor

est31 commented Jun 7, 2019 •
edited

Fourth and final PR in a series of PRs to remove unused/dead code from servo, powered by an (upcoming) tool of mine. Please take a look and tell me if you want to keep something.

Shortstat of the combined PR series:

47 files changed, 7 insertions(+), 805 deletions(-)
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes OR
  • These changes do not require tests because they only remove dead code

This change is Reviewable
@highfive
Copy link

highfive commented Jun 7, 2019

Heads up! This PR modifies the following files:

  • @emilio: components/style/sharing/mod.rs, components/style/stylesheets/import_rule.rs, components/style/invalidation/element/restyle_hints.rs, components/style/values/specified/source_size_list.rs, components/style/data.rs and 5 more
@highfive
Copy link

highfive commented Jun 7, 2019

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
emilio approved these changes Jun 7, 2019
View changes
Copy link
Member

emilio left a comment

Thanks!
components/selectors/matching.rs Outdated Show resolved Hide resolved
components/style/logical_geometry.rs Outdated Show resolved Hide resolved
@est31
Remove unused code from selector and style crates
Loading status checks…
642b7c3
@est31 est31 force-pushed the est31:unused_code_removal_4 branch from a6b4c51 to 642b7c3 Jun 7, 2019
@est31
Copy link
Contributor Author

est31 commented Jun 7, 2019

re-added the parts. r? @emilio
@highfive highfive assigned emilio and unassigned paulrouget Jun 7, 2019
@jdm
Copy link
Member

jdm commented Jun 7, 2019

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

📌 Commit 642b7c3 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

⌛ Testing commit 642b7c3 with merge ffa2be4...
bors-servo added a commit that referenced this pull request Jun 7, 2019
@bors-servo
Auto merge of #23532 - est31:unused_code_removal_4, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ffa2be4 
Remove unused code (4/4)

<!-- Please describe your changes on the following line: -->

Fourth and final PR in a series of PRs to remove unused/dead code from servo, powered by an (upcoming) tool of mine. Please take a look and tell me if you want to keep something.

* First PR: #23477
* Second PR: #23498
* Third PR: #23499

Shortstat of the combined PR series:
```
47 files changed, 7 insertions(+), 805 deletions(-)
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they only remove dead code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23532)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jun 7, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2019

⌛ Testing commit 642b7c3 with merge 0d5c6a0...
bors-servo added a commit that referenced this pull request Jun 8, 2019
@bors-servo
Auto merge of #23532 - est31:unused_code_removal_4, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0d5c6a0 
Remove unused code (4/4)

<!-- Please describe your changes on the following line: -->

Fourth and final PR in a series of PRs to remove unused/dead code from servo, powered by an (upcoming) tool of mine. Please take a look and tell me if you want to keep something.

* First PR: #23477
* Second PR: #23498
* Third PR: #23499

Shortstat of the combined PR series:
```
47 files changed, 7 insertions(+), 805 deletions(-)
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they only remove dead code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23532)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: emilio
Pushing 0d5c6a0 to master...
@bors-servo bors-servo merged commit 642b7c3 into servo:master Jun 8, 2019
4 checks passed
4 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@est31 @highfive @jdm @bors-servo @emilio @paulrouget
You can’t perform that action at this time.