Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing NavigatorId attributes #23551

Merged
merged 3 commits into from Jun 12, 2019
Merged

Added missing NavigatorId attributes #23551

merged 3 commits into from Jun 12, 2019

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jun 11, 2019 •
edited by SimonSapin

Add the missing attributes from https://html.spec.whatwg.org/multipage/system-state.html#navigatorid

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because there are already tests for Navigator

This change is Reviewable
@asajeffrey
Added missing NavigatorId attributes
Loading status checks…
4cfd62a
@highfive
Copy link

highfive commented Jun 11, 2019

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/workernavigator.rs, components/script/dom/navigatorinfo.rs, components/script/dom/navigator.rs, components/script/dom/webidls/Navigator.webidl
@highfive
Copy link

highfive commented Jun 11, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 11, 2019

These missing attributes are blockers for running sketchfab:

./mach run -r --pref dom.webvr.enabled --pref dom.webvr.test --pref dom.gamepad.enabled https://sketchfab.com/3d-models/disco-ball-ff4fcb7af1e248c2964c18e8779f1bd7
[2019-06-11T16:18:34Z ERROR script::dom::bindings::error] Error at https://static.sketchfab.com/static/builds/web/dist/viewer-a8c3ce6e8219e56349b21857ce328c62.js:1:556278 navigator.vendor is undefined
[2019-06-11T16:18:34Z ERROR offscreen_gl_context::draw_buffer] The given GLContext doesn't support requested antialising

Unfortunately fixing this just causes other errors, but we may as well fix this.
@asajeffrey asajeffrey mentioned this pull request Jun 11, 2019
Open
@jdm
Copy link
Member

jdm commented Jun 11, 2019

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Jun 11, 2019
@bors-servo
Auto merge of #23551 - asajeffrey:script-navigatorid, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
00e7ba5 
Added missing NavigatorId attributes

<!-- Please describe your changes on the following line: -->

Add the missing attributes from https://html.spec.whatwg.org/multipage/system-state.html#navigatorid

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because there are already tests for Navigator

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23551)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2019

⌛ Trying commit 4cfd62a with merge 00e7ba5...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Jun 11, 2019

A bunch of failures caused by #23332.
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 11, 2019

Hmm, is the best bet to mark those tests as having expectation FAIL, or wait until #23332 is fixed?
@jdm
Copy link
Member

jdm commented Jun 11, 2019

Mark them as failed.
@asajeffrey
Update test expectations
Loading status checks…
d3256d7
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 11, 2019

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Jun 11, 2019
@bors-servo
Auto merge of #23551 - asajeffrey:script-navigatorid, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fb0b940 
Added missing NavigatorId attributes

<!-- Please describe your changes on the following line: -->

Add the missing attributes from https://html.spec.whatwg.org/multipage/system-state.html#navigatorid

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because there are already tests for Navigator

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23551)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2019

⌛ Trying commit d3256d7 with merge fb0b940...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 11, 2019

💔 Test failed - linux-rel-wpt
@asajeffrey
Updated more test expectations
Loading status checks…
54ba32b
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 12, 2019

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Jun 12, 2019
@bors-servo
Auto merge of #23551 - asajeffrey:script-navigatorid, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6955e25 
Added missing NavigatorId attributes

<!-- Please describe your changes on the following line: -->

Add the missing attributes from https://html.spec.whatwg.org/multipage/system-state.html#navigatorid

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because there are already tests for Navigator

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23551)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2019

⌛ Trying commit 54ba32b with merge 6955e25...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True
@asajeffrey
Copy link
Member Author

asajeffrey commented Jun 12, 2019

r? @jdm
@highfive highfive assigned jdm and unassigned ferjm Jun 12, 2019
@jdm
Copy link
Member

jdm commented Jun 12, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2019

📌 Commit 54ba32b has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2019

⌛ Testing commit 54ba32b with merge a74f38f...
bors-servo added a commit that referenced this pull request Jun 12, 2019
@bors-servo
Auto merge of #23551 - asajeffrey:script-navigatorid, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a74f38f 
Added missing NavigatorId attributes

<!-- Please describe your changes on the following line: -->

Add the missing attributes from https://html.spec.whatwg.org/multipage/system-state.html#navigatorid

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because there are already tests for Navigator

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23551)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing a74f38f to master...
@bors-servo bors-servo merged commit 54ba32b into servo:master Jun 12, 2019
2 of 4 checks passed
2 of 4 checks passed
Travis CI - Pull Request Build Failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
A-content/script
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@asajeffrey @highfive @jdm @bors-servo @ferjm
You can’t perform that action at this time.